Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 682223002: rename GrTextureDesc->GrSurfaceDesc, GrTextureFlags->GrSurfaceFlags (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rename GrTextureDesc->GrSurfaceDesc, GrTextureFlags->GrSurfaceFlags Committed: https://skia.googlesource.com/skia/+/f2703d83da3ab2ae18b45231fd4f11e16cce3184

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Patch Set 3 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -226 lines) Patch
M bench/GrResourceCacheBench.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M gm/gmmain.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/texdata.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 6 chunks +8 lines, -8 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrSurface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTypes.h View 1 2 6 chunks +25 lines, -22 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlas.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskCache.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrContext.cpp View 13 chunks +25 lines, -25 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrLayerCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTexture.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrTexturePriv.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/SkGr.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/BlurTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ClipCacheTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/FloatingPointTextureTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrSurfaceTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bsalomon
Purely mechanical except GrTypes.h, GrAtlas.cpp, and GrDistanceFieldTextContext.cpp. The latter two included deleted references to kDynamicUpdate ...
6 years, 1 month ago (2014-10-28 20:55:31 UTC) #2
joshualitt
https://codereview.chromium.org/682223002/diff/1/include/gpu/GrTypes.h File include/gpu/GrTypes.h (right): https://codereview.chromium.org/682223002/diff/1/include/gpu/GrTypes.h#newcode502 include/gpu/GrTypes.h:502: typedef GrSurfaceDesc GrTextureDescx; GrTextureDesc?
6 years, 1 month ago (2014-10-28 21:03:00 UTC) #3
bsalomon
https://codereview.chromium.org/682223002/diff/1/include/gpu/GrTypes.h File include/gpu/GrTypes.h (right): https://codereview.chromium.org/682223002/diff/1/include/gpu/GrTypes.h#newcode502 include/gpu/GrTypes.h:502: typedef GrSurfaceDesc GrTextureDescx; On 2014/10/28 21:03:00, joshualitt wrote: > ...
6 years, 1 month ago (2014-10-28 21:11:49 UTC) #4
joshualitt
On 2014/10/28 21:11:49, bsalomon wrote: > https://codereview.chromium.org/682223002/diff/1/include/gpu/GrTypes.h > File include/gpu/GrTypes.h (right): > > https://codereview.chromium.org/682223002/diff/1/include/gpu/GrTypes.h#newcode502 > ...
6 years, 1 month ago (2014-10-28 21:12:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682223002/20001
6 years, 1 month ago (2014-10-28 21:12:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/302)
6 years, 1 month ago (2014-10-28 21:14:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682223002/40001
6 years, 1 month ago (2014-10-28 21:23:48 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 21:33:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as f2703d83da3ab2ae18b45231fd4f11e16cce3184

Powered by Google App Engine
This is Rietveld 408576698