Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
haraken, adamk, rwlbuis
CC:
aandrey+blink_chromium.org, abarth-chromium, darktears, apavlov+blink_chromium.org, arv+blink, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, Eric Willigers, eustas+blink_chromium.org, f(malita), fs, gasubic, gyuyoung.kim_webkit.org, jamesr, jbroman, jchaffraix+rendering, kenneth.christiansen, kinuko+fileapi, kouhei+svg_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), nhiroki, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, philipj_slow, rjwright, rwlbuis, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, shans, sof, nessy, Steve Block, Timothy Loh, tyoshino+watch_chromium.org, tzik, vcarbune.chromium, vsevik+blink_chromium.org, yhirano+watch_chromium.org, Yoav Weiss, yurys+blink_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible instead of StringBuilder::append(char*), as this is a bit more efficient. R=adamk@chromium.org, rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -205 lines) Patch
M Source/bindings/core/v8/ExceptionMessages.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterValue.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSImportRule.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSMediaRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPropertySourceData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSupportsRule.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaQuery.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/MediaQuerySetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/parser/BisonCSSParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolverStats.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameConsole.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/EmailInputType.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/FormController.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptArguments.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/GraphicsContextAnnotator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathStringBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystem.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketExtensionDispatcher.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M Source/platform/JSONValues.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/PODInterval.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/PODRedBlackTree.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/UUID.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/animation/TimingFunction.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/Color.cpp View 2 chunks +9 lines, -11 lines 0 comments Download
M Source/platform/mhtml/MHTMLArchive.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M Source/platform/network/ProxyServer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/text/DateTimeFormat.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/text/LocaleWin.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/text/PlatformLocale.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/weborigin/SchemeRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/LocaleICUTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 4 months ago (2014-08-18 15:49:35 UTC) #1
haraken
LGTM. Thanks for making the sweep change!
6 years, 4 months ago (2014-08-18 15:57:13 UTC) #2
Inactive
adamk@, could you please take a look at Source/platform/ and Source/web ?
6 years, 4 months ago (2014-08-18 20:17:16 UTC) #3
adamk
lgtm
6 years, 4 months ago (2014-08-18 20:20:40 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-18 21:12:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/482753002/1
6 years, 4 months ago (2014-08-18 21:13:18 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 21:37:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180497

Powered by Google App Engine
This is Rietveld 408576698