Source/core/frame/FrameConsole.cpp - Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameConsole.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameConsole.cpp

diff --git a/Source/core/frame/FrameConsole.cpp b/Source/core/frame/FrameConsole.cpp

index 28dc4d3da49113cd0162f15067ff2b393264a289..5c42d4457d0ff69a841a9eeabea487aaff5ce751 100644

--- a/Source/core/frame/FrameConsole.cpp

+++ b/Source/core/frame/FrameConsole.cpp

@@ -89,7 +89,7 @@ String FrameConsole::formatStackTraceString(const String& originalMessage, PassR

for (size_t i = 0; i < callStack->size(); ++i) {

const ScriptCallFrame& frame = callStack->at(i);

stackTrace.append("\n at " + (frame.functionName().length() ? frame.functionName() : "(anonymous function)"));

- stackTrace.append(" (");

+ stackTrace.appendLiteral(" (");

stackTrace.append(frame.sourceURL());

stackTrace.append(':');

stackTrace.append(String::number(frame.lineNumber()));

« no previous file with comments | « Source/core/fileapi/FileReaderLoader.cpp ('k') | Source/core/html/ImageDocument.cpp » ('j') | no next file with comments »