Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGPathStringBuilder.cpp ('k') | Source/modules/filesystem/DOMFileSystem.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1901 matching lines...) Expand 10 before | Expand all | Expand 10 after
1912 { 1912 {
1913 ASSERT(document); 1913 ASSERT(document);
1914 if (!document->frame()) { 1914 if (!document->frame()) {
1915 exceptionState.throwDOMException(InvalidAccessError, "The document provi ded is invalid."); 1915 exceptionState.throwDOMException(InvalidAccessError, "The document provi ded is invalid.");
1916 return String(); 1916 return String();
1917 } 1917 }
1918 1918
1919 Cursor cursor = document->frame()->eventHandler().currentMouseCursor(); 1919 Cursor cursor = document->frame()->eventHandler().currentMouseCursor();
1920 1920
1921 StringBuilder result; 1921 StringBuilder result;
1922 result.append("type="); 1922 result.appendLiteral("type=");
1923 result.append(cursorTypeToString(cursor.type())); 1923 result.append(cursorTypeToString(cursor.type()));
1924 result.append(" hotSpot="); 1924 result.appendLiteral(" hotSpot=");
1925 result.appendNumber(cursor.hotSpot().x()); 1925 result.appendNumber(cursor.hotSpot().x());
1926 result.append(","); 1926 result.append(',');
1927 result.appendNumber(cursor.hotSpot().y()); 1927 result.appendNumber(cursor.hotSpot().y());
1928 if (cursor.image()) { 1928 if (cursor.image()) {
1929 IntSize size = cursor.image()->size(); 1929 IntSize size = cursor.image()->size();
1930 result.append(" image="); 1930 result.appendLiteral(" image=");
1931 result.appendNumber(size.width()); 1931 result.appendNumber(size.width());
1932 result.append("x"); 1932 result.append('x');
1933 result.appendNumber(size.height()); 1933 result.appendNumber(size.height());
1934 } 1934 }
1935 if (cursor.imageScaleFactor() != 1) { 1935 if (cursor.imageScaleFactor() != 1) {
1936 result.append(" scale="); 1936 result.appendLiteral(" scale=");
1937 NumberToStringBuffer buffer; 1937 NumberToStringBuffer buffer;
1938 result.append(numberToFixedPrecisionString(cursor.imageScaleFactor(), 8, buffer, true)); 1938 result.append(numberToFixedPrecisionString(cursor.imageScaleFactor(), 8, buffer, true));
1939 } 1939 }
1940 1940
1941 return result.toString(); 1941 return result.toString();
1942 } 1942 }
1943 1943
1944 PassRefPtr<ArrayBuffer> Internals::serializeObject(PassRefPtr<SerializedScriptVa lue> value) const 1944 PassRefPtr<ArrayBuffer> Internals::serializeObject(PassRefPtr<SerializedScriptVa lue> value) const
1945 { 1945 {
1946 String stringValue = value->toWireString(); 1946 String stringValue = value->toWireString();
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
2220 { 2220 {
2221 Vector<Document::TransitionElementData> elementData; 2221 Vector<Document::TransitionElementData> elementData;
2222 frame()->document()->getTransitionElementData(elementData); 2222 frame()->document()->getTransitionElementData(elementData);
2223 2223
2224 Vector<Document::TransitionElementData>::iterator iter = elementData.begin() ; 2224 Vector<Document::TransitionElementData>::iterator iter = elementData.begin() ;
2225 for (; iter != elementData.end(); ++iter) 2225 for (; iter != elementData.end(); ++iter)
2226 frame()->document()->hideTransitionElements(AtomicString(iter->selector) ); 2226 frame()->document()->hideTransitionElements(AtomicString(iter->selector) );
2227 } 2227 }
2228 2228
2229 } // namespace blink 2229 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/svg/SVGPathStringBuilder.cpp ('k') | Source/modules/filesystem/DOMFileSystem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698