Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: Source/core/css/CSSPropertySourceData.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/CSSMediaRule.cpp ('k') | Source/core/css/CSSSelectorList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 } 86 }
87 87
88 String CSSPropertySourceData::toString() const 88 String CSSPropertySourceData::toString() const
89 { 89 {
90 DEFINE_STATIC_LOCAL(String, emptyValue, ("e")); 90 DEFINE_STATIC_LOCAL(String, emptyValue, ("e"));
91 if (!name && value == emptyValue) 91 if (!name && value == emptyValue)
92 return String(); 92 return String();
93 93
94 StringBuilder result; 94 StringBuilder result;
95 if (disabled) 95 if (disabled)
96 result.append("/* "); 96 result.appendLiteral("/* ");
97 result.append(name); 97 result.append(name);
98 result.appendLiteral(": "); 98 result.appendLiteral(": ");
99 result.append(value); 99 result.append(value);
100 if (important) 100 if (important)
101 result.appendLiteral(" !important"); 101 result.appendLiteral(" !important");
102 result.append(';'); 102 result.append(';');
103 if (disabled) 103 if (disabled)
104 result.append(" */"); 104 result.appendLiteral(" */");
105 return result.toString(); 105 return result.toString();
106 } 106 }
107 107
108 unsigned CSSPropertySourceData::hash() const 108 unsigned CSSPropertySourceData::hash() const
109 { 109 {
110 return StringHash::hash(name) + 3 * StringHash::hash(value) + 7 * important + 13 * parsedOk + 31; 110 return StringHash::hash(name) + 3 * StringHash::hash(value) + 7 * important + 13 * parsedOk + 31;
111 } 111 }
112 112
113 void CSSRuleSourceData::trace(Visitor* visitor) 113 void CSSRuleSourceData::trace(Visitor* visitor)
114 { 114 {
115 visitor->trace(ruleHeaderRange); 115 visitor->trace(ruleHeaderRange);
116 visitor->trace(ruleBodyRange); 116 visitor->trace(ruleBodyRange);
117 visitor->trace(selectorRanges); 117 visitor->trace(selectorRanges);
118 visitor->trace(styleSourceData); 118 visitor->trace(styleSourceData);
119 visitor->trace(childRules); 119 visitor->trace(childRules);
120 } 120 }
121 121
122 } // namespace blink 122 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/CSSMediaRule.cpp ('k') | Source/core/css/CSSSelectorList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698