Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible

Source/platform/graphics/Color.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 176 matching lines @@
         return parseHexColor(name.characters8() + 1, name.length() - 1, m_color);
     return parseHexColor(name.characters16() + 1, name.length() - 1, m_color);
 }
 
 String Color::serializedAsCSSComponentValue() const
 {
     StringBuilder result;
     result.reserveCapacity(32);
     bool colorHasAlpha = hasAlpha();
     if (colorHasAlpha)
-        result.append("rgba(", 5);
+        result.appendLiteral("rgba(");
     else
-        result.append("rgb(", 4);
+        result.appendLiteral("rgb(");
 
     result.appendNumber(static_cast<unsigned char>(red()));
-    result.append(", ", 2);
+    result.appendLiteral(", ");
 
     result.appendNumber(static_cast<unsigned char>(green()));
-    result.append(", ", 2);
+    result.appendLiteral(", ");
 
     result.appendNumber(static_cast<unsigned char>(blue()));
     if (colorHasAlpha) {
-        result.append(", ", 2);
+        result.appendLiteral(", ");
 
         NumberToStringBuffer buffer;
         const char* alphaString = numberToFixedPrecisionString(alpha() / 255.0f, 6, buffer, true);
         result.append(alphaString, strlen(alphaString));
     }
 
     result.append(')');
     return result.toString();
 }
 
 String Color::serialized() const
 {
     if (!hasAlpha()) {
         StringBuilder builder;
         builder.reserveCapacity(7);
         builder.append('#');
         appendByteAsHex(red(), builder, Lowercase);
         appendByteAsHex(green(), builder, Lowercase);
         appendByteAsHex(blue(), builder, Lowercase);
         return builder.toString();
     }
 
     StringBuilder result;
     result.reserveCapacity(28);
-    const char commaSpace[] = ", ";
-    const char rgbaParen[] = "rgba(";
 
-    result.append(rgbaParen, 5);
+    result.appendLiteral("rgba(");
     result.appendNumber(red());
-    result.append(commaSpace, 2);
+    result.appendLiteral(", ");
     result.appendNumber(green());
-    result.append(commaSpace, 2);
+    result.appendLiteral(", ");
     result.appendNumber(blue());
-    result.append(commaSpace, 2);
+    result.appendLiteral(", ");
 
     if (!alpha())
         result.append('0');
     else {
         result.append(Decimal::fromDouble(alpha() / 255.0).toString());
     }
 
     result.append(')');
     return result.toString();
 }
@@ skipping 204 matching lines @@
             (color.green() * alpha  + 254) / 255,
             (color.blue() * alpha  + 254) / 255,
             alpha).rgb();
     } else
          pixelColor = color.rgb();
 
     return pixelColor;
 }
 
 } // namespace blink