Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: Source/core/inspector/ScriptArguments.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.cpp ('k') | Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 result = false; 124 result = false;
125 break; 125 break;
126 } 126 }
127 } 127 }
128 m_visitedArrays.removeLast(); 128 m_visitedArrays.removeLast();
129 return result; 129 return result;
130 } 130 }
131 131
132 bool append(v8::Handle<v8::Symbol> symbol) 132 bool append(v8::Handle<v8::Symbol> symbol)
133 { 133 {
134 m_builder.append("Symbol("); 134 m_builder.appendLiteral("Symbol(");
135 bool result = append(symbol->Name(), IgnoreUndefined); 135 bool result = append(symbol->Name(), IgnoreUndefined);
136 m_builder.append(')'); 136 m_builder.append(')');
137 return result; 137 return result;
138 } 138 }
139 139
140 bool append(v8::Handle<v8::String> string) 140 bool append(v8::Handle<v8::String> string)
141 { 141 {
142 if (m_tryCatch.HasCaught()) 142 if (m_tryCatch.HasCaught())
143 return false; 143 return false;
144 if (!string.IsEmpty()) 144 if (!string.IsEmpty())
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 const ScriptValue& value = argumentAt(0); 189 const ScriptValue& value = argumentAt(0);
190 ScriptState::Scope scope(m_scriptState.get()); 190 ScriptState::Scope scope(m_scriptState.get());
191 if (checkForNullOrUndefined && (value.isNull() || value.isUndefined())) 191 if (checkForNullOrUndefined && (value.isNull() || value.isUndefined()))
192 return false; 192 return false;
193 193
194 result = V8ValueStringBuilder::toString(value.v8Value(), value.isolate()); 194 result = V8ValueStringBuilder::toString(value.v8Value(), value.isolate());
195 return true; 195 return true;
196 } 196 }
197 197
198 } // namespace blink 198 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.cpp ('k') | Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698