Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Side by Side Diff: Source/core/dom/DatasetDOMStringMap.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/resolver/StyleResolverStats.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 return false; 118 return false;
119 } 119 }
120 return true; 120 return true;
121 } 121 }
122 122
123 // This returns an AtomicString because attribute names are always stored 123 // This returns an AtomicString because attribute names are always stored
124 // as AtomicString types in Element (see setAttribute()). 124 // as AtomicString types in Element (see setAttribute()).
125 static AtomicString convertPropertyNameToAttributeName(const String& name) 125 static AtomicString convertPropertyNameToAttributeName(const String& name)
126 { 126 {
127 StringBuilder builder; 127 StringBuilder builder;
128 builder.append("data-"); 128 builder.appendLiteral("data-");
129 129
130 unsigned length = name.length(); 130 unsigned length = name.length();
131 for (unsigned i = 0; i < length; ++i) { 131 for (unsigned i = 0; i < length; ++i) {
132 UChar character = name[i]; 132 UChar character = name[i];
133 if (isASCIIUpper(character)) { 133 if (isASCIIUpper(character)) {
134 builder.append('-'); 134 builder.append('-');
135 builder.append(toASCIILower(character)); 135 builder.append(toASCIILower(character));
136 } else 136 } else
137 builder.append(character); 137 builder.append(character);
138 } 138 }
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 return false; 207 return false;
208 } 208 }
209 209
210 void DatasetDOMStringMap::trace(Visitor* visitor) 210 void DatasetDOMStringMap::trace(Visitor* visitor)
211 { 211 {
212 visitor->trace(m_element); 212 visitor->trace(m_element);
213 DOMStringMap::trace(visitor); 213 DOMStringMap::trace(visitor);
214 } 214 }
215 215
216 } // namespace blink 216 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/resolver/StyleResolverStats.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698