Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: Source/platform/animation/TimingFunction.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/platform/UUID.cpp ('k') | Source/platform/graphics/Color.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "platform/animation/TimingFunction.h" 6 #include "platform/animation/TimingFunction.h"
7 7
8 #include "wtf/MathExtras.h" 8 #include "wtf/MathExtras.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 case StepsTimingFunction::Start: 118 case StepsTimingFunction::Start:
119 return "step-start"; 119 return "step-start";
120 case StepsTimingFunction::Middle: 120 case StepsTimingFunction::Middle:
121 return "step-middle"; 121 return "step-middle";
122 case StepsTimingFunction::End: 122 case StepsTimingFunction::End:
123 return "step-end"; 123 return "step-end";
124 case StepsTimingFunction::Custom: 124 case StepsTimingFunction::Custom:
125 builder.append("steps(" + String::numberToStringECMAScript(this->numberO fSteps()) + ", "); 125 builder.append("steps(" + String::numberToStringECMAScript(this->numberO fSteps()) + ", ");
126 126
127 if (this->stepAtPosition() == StepsTimingFunction::StepAtStart) 127 if (this->stepAtPosition() == StepsTimingFunction::StepAtStart)
128 builder.append("start"); 128 builder.appendLiteral("start");
129 else if (this->stepAtPosition() == StepsTimingFunction::StepAtMiddle) 129 else if (this->stepAtPosition() == StepsTimingFunction::StepAtMiddle)
130 builder.append("middle"); 130 builder.appendLiteral("middle");
131 else if (this->stepAtPosition() == StepsTimingFunction::StepAtEnd) 131 else if (this->stepAtPosition() == StepsTimingFunction::StepAtEnd)
132 builder.append("end"); 132 builder.appendLiteral("end");
133 else 133 else
134 ASSERT_NOT_REACHED(); 134 ASSERT_NOT_REACHED();
135 135
136 builder.append(")"); 136 builder.append(')');
137 break; 137 break;
138 default: 138 default:
139 ASSERT_NOT_REACHED(); 139 ASSERT_NOT_REACHED();
140 } 140 }
141 return builder.toString(); 141 return builder.toString();
142 } 142 }
143 143
144 void StepsTimingFunction::range(double* minValue, double* maxValue) const 144 void StepsTimingFunction::range(double* minValue, double* maxValue) const
145 { 145 {
146 *minValue = 0; 146 *minValue = 0;
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 return false; 220 return false;
221 } 221 }
222 222
223 // No need to define specific operator!= as they can all come via this function. 223 // No need to define specific operator!= as they can all come via this function.
224 bool operator!=(const TimingFunction& lhs, const TimingFunction& rhs) 224 bool operator!=(const TimingFunction& lhs, const TimingFunction& rhs)
225 { 225 {
226 return !(lhs == rhs); 226 return !(lhs == rhs);
227 } 227 }
228 228
229 } // namespace blink 229 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/UUID.cpp ('k') | Source/platform/graphics/Color.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698