Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: Source/core/css/CSSFilterValue.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/css/CSSImageSetValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 23 matching lines...) Expand all
34 : CSSValueList(CSSFilterClass, CommaSeparator) 34 : CSSValueList(CSSFilterClass, CommaSeparator)
35 , m_type(operationType) 35 , m_type(operationType)
36 { 36 {
37 } 37 }
38 38
39 String CSSFilterValue::customCSSText() const 39 String CSSFilterValue::customCSSText() const
40 { 40 {
41 StringBuilder result; 41 StringBuilder result;
42 switch (m_type) { 42 switch (m_type) {
43 case ReferenceFilterOperation: 43 case ReferenceFilterOperation:
44 result.append("url("); 44 result.appendLiteral("url(");
45 break; 45 break;
46 case GrayscaleFilterOperation: 46 case GrayscaleFilterOperation:
47 result.append("grayscale("); 47 result.appendLiteral("grayscale(");
48 break; 48 break;
49 case SepiaFilterOperation: 49 case SepiaFilterOperation:
50 result.append("sepia("); 50 result.appendLiteral("sepia(");
51 break; 51 break;
52 case SaturateFilterOperation: 52 case SaturateFilterOperation:
53 result.append("saturate("); 53 result.appendLiteral("saturate(");
54 break; 54 break;
55 case HueRotateFilterOperation: 55 case HueRotateFilterOperation:
56 result.append("hue-rotate("); 56 result.appendLiteral("hue-rotate(");
57 break; 57 break;
58 case InvertFilterOperation: 58 case InvertFilterOperation:
59 result.append("invert("); 59 result.appendLiteral("invert(");
60 break; 60 break;
61 case OpacityFilterOperation: 61 case OpacityFilterOperation:
62 result.append("opacity("); 62 result.appendLiteral("opacity(");
63 break; 63 break;
64 case BrightnessFilterOperation: 64 case BrightnessFilterOperation:
65 result.append("brightness("); 65 result.appendLiteral("brightness(");
66 break; 66 break;
67 case ContrastFilterOperation: 67 case ContrastFilterOperation:
68 result.append("contrast("); 68 result.appendLiteral("contrast(");
69 break; 69 break;
70 case BlurFilterOperation: 70 case BlurFilterOperation:
71 result.append("blur("); 71 result.appendLiteral("blur(");
72 break; 72 break;
73 case DropShadowFilterOperation: 73 case DropShadowFilterOperation:
74 result.append("drop-shadow("); 74 result.appendLiteral("drop-shadow(");
75 break; 75 break;
76 default: 76 default:
77 break; 77 break;
78 } 78 }
79 79
80 result.append(CSSValueList::customCSSText()); 80 result.append(CSSValueList::customCSSText());
81 result.append(')'); 81 result.append(')');
82 return result.toString(); 82 return result.toString();
83 } 83 }
84 84
85 CSSFilterValue::CSSFilterValue(const CSSFilterValue& cloneFrom) 85 CSSFilterValue::CSSFilterValue(const CSSFilterValue& cloneFrom)
86 : CSSValueList(cloneFrom) 86 : CSSValueList(cloneFrom)
87 , m_type(cloneFrom.m_type) 87 , m_type(cloneFrom.m_type)
88 { 88 {
89 } 89 }
90 90
91 PassRefPtrWillBeRawPtr<CSSFilterValue> CSSFilterValue::cloneForCSSOM() const 91 PassRefPtrWillBeRawPtr<CSSFilterValue> CSSFilterValue::cloneForCSSOM() const
92 { 92 {
93 return adoptRefWillBeNoop(new CSSFilterValue(*this)); 93 return adoptRefWillBeNoop(new CSSFilterValue(*this));
94 } 94 }
95 95
96 bool CSSFilterValue::equals(const CSSFilterValue& other) const 96 bool CSSFilterValue::equals(const CSSFilterValue& other) const
97 { 97 {
98 return m_type == other.m_type && CSSValueList::equals(other); 98 return m_type == other.m_type && CSSValueList::equals(other);
99 } 99 }
100 100
101 } 101 }
102 102
OLDNEW
« no previous file with comments | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/css/CSSImageSetValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698