Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: Source/core/css/CSSBasicShapes.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/core/v8/ExceptionMessages.h ('k') | Source/core/css/CSSCalculationValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 if (!centerX.isNull() || !centerY.isNull()) { 53 if (!centerX.isNull() || !centerY.isNull()) {
54 if (!radius.isNull()) 54 if (!radius.isNull())
55 result.appendLiteral(separator); 55 result.appendLiteral(separator);
56 result.append(at); 56 result.append(at);
57 result.appendLiteral(separator); 57 result.appendLiteral(separator);
58 result.append(centerX); 58 result.append(centerX);
59 result.appendLiteral(separator); 59 result.appendLiteral(separator);
60 result.append(centerY); 60 result.append(centerY);
61 } 61 }
62 result.append(")"); 62 result.append(')');
63 if (box.length()) { 63 if (box.length()) {
64 result.appendLiteral(separator); 64 result.appendLiteral(separator);
65 result.append(box); 65 result.append(box);
66 } 66 }
67 return result.toString(); 67 return result.toString();
68 } 68 }
69 69
70 static String serializePositionOffset(const Pair& offset, const Pair& other) 70 static String serializePositionOffset(const Pair& offset, const Pair& other)
71 { 71 {
72 if ((offset.first()->getValueID() == CSSValueLeft && other.first()->getValue ID() == CSSValueTop) 72 if ((offset.first()->getValueID() == CSSValueLeft && other.first()->getValue ID() == CSSValueTop)
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 164
165 if (!centerX.isNull() || !centerY.isNull()) { 165 if (!centerX.isNull() || !centerY.isNull()) {
166 if (needsSeparator) 166 if (needsSeparator)
167 result.appendLiteral(separator); 167 result.appendLiteral(separator);
168 result.appendLiteral(at); 168 result.appendLiteral(at);
169 result.appendLiteral(separator); 169 result.appendLiteral(separator);
170 result.append(centerX); 170 result.append(centerX);
171 result.appendLiteral(separator); 171 result.appendLiteral(separator);
172 result.append(centerY); 172 result.append(centerY);
173 } 173 }
174 result.append(")"); 174 result.append(')');
175 if (box.length()) { 175 if (box.length()) {
176 result.appendLiteral(separator); 176 result.appendLiteral(separator);
177 result.append(box); 177 result.append(box);
178 } 178 }
179 return result.toString(); 179 return result.toString();
180 } 180 }
181 181
182 String CSSBasicShapeEllipse::cssText() const 182 String CSSBasicShapeEllipse::cssText() const
183 { 183 {
184 RefPtrWillBeRawPtr<CSSPrimitiveValue> normalizedCX = buildSerializablePositi onOffset(m_centerX, CSSValueLeft); 184 RefPtrWillBeRawPtr<CSSPrimitiveValue> normalizedCX = buildSerializablePositi onOffset(m_centerX, CSSValueLeft);
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 visitor->trace(m_left); 443 visitor->trace(m_left);
444 visitor->trace(m_topLeftRadius); 444 visitor->trace(m_topLeftRadius);
445 visitor->trace(m_topRightRadius); 445 visitor->trace(m_topRightRadius);
446 visitor->trace(m_bottomRightRadius); 446 visitor->trace(m_bottomRightRadius);
447 visitor->trace(m_bottomLeftRadius); 447 visitor->trace(m_bottomLeftRadius);
448 CSSBasicShape::trace(visitor); 448 CSSBasicShape::trace(visitor);
449 } 449 }
450 450
451 } // namespace blink 451 } // namespace blink
452 452
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ExceptionMessages.h ('k') | Source/core/css/CSSCalculationValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698