Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: Source/platform/UUID.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/platform/PODRedBlackTree.h ('k') | Source/platform/animation/TimingFunction.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 39
40 String createCanonicalUUIDString() 40 String createCanonicalUUIDString()
41 { 41 {
42 unsigned randomData[4]; 42 unsigned randomData[4];
43 cryptographicallyRandomValues(reinterpret_cast<unsigned char*>(randomData), sizeof(randomData)); 43 cryptographicallyRandomValues(reinterpret_cast<unsigned char*>(randomData), sizeof(randomData));
44 44
45 // Format as Version 4 UUID. 45 // Format as Version 4 UUID.
46 StringBuilder builder; 46 StringBuilder builder;
47 builder.reserveCapacity(36); 47 builder.reserveCapacity(36);
48 appendUnsignedAsHexFixedSize(randomData[0], builder, 8, Lowercase); 48 appendUnsignedAsHexFixedSize(randomData[0], builder, 8, Lowercase);
49 builder.append("-"); 49 builder.append('-');
50 appendUnsignedAsHexFixedSize(randomData[1] >> 16, builder, 4, Lowercase); 50 appendUnsignedAsHexFixedSize(randomData[1] >> 16, builder, 4, Lowercase);
51 builder.append("-4"); 51 builder.appendLiteral("-4");
52 appendUnsignedAsHexFixedSize(randomData[1] & 0x00000fff, builder, 3, Lowerca se); 52 appendUnsignedAsHexFixedSize(randomData[1] & 0x00000fff, builder, 3, Lowerca se);
53 builder.append("-"); 53 builder.append('-');
54 appendUnsignedAsHexFixedSize((randomData[2] >> 30) | 0x8, builder, 1, Lowerc ase); 54 appendUnsignedAsHexFixedSize((randomData[2] >> 30) | 0x8, builder, 1, Lowerc ase);
55 appendUnsignedAsHexFixedSize((randomData[2] >> 16) & 0x00000fff, builder, 3, Lowercase); 55 appendUnsignedAsHexFixedSize((randomData[2] >> 16) & 0x00000fff, builder, 3, Lowercase);
56 builder.append("-"); 56 builder.append('-');
57 appendUnsignedAsHexFixedSize(randomData[2] & 0x0000ffff, builder, 4, Lowerca se); 57 appendUnsignedAsHexFixedSize(randomData[2] & 0x0000ffff, builder, 4, Lowerca se);
58 appendUnsignedAsHexFixedSize(randomData[3], builder, 8, Lowercase); 58 appendUnsignedAsHexFixedSize(randomData[3], builder, 8, Lowercase);
59 return builder.toString(); 59 return builder.toString();
60 } 60 }
61 61
62 } 62 }
OLDNEW
« no previous file with comments | « Source/platform/PODRedBlackTree.h ('k') | Source/platform/animation/TimingFunction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698