Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible

Source/platform/mhtml/MHTMLArchive.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 39 matching lines @@
 const char* const base64 = "base64";
 const char* const binary = "binary";
 
 static String generateRandomBoundary()
 {
     // Trying to generate random boundaries similar to IE/UnMHT (ex: ----=_NextPart_000_001B_01CC157B.96F808A0).
     const size_t randomValuesLength = 10;
     char randomValues[randomValuesLength];
     cryptographicallyRandomValues(&randomValues, randomValuesLength);
     StringBuilder stringBuilder;
-    stringBuilder.append("----=_NextPart_000_");
+    stringBuilder.appendLiteral("----=_NextPart_000_");
     for (size_t i = 0; i < randomValuesLength; ++i) {
         if (i == 2)
             stringBuilder.append('_');
         else if (i == 6)
             stringBuilder.append('.');
         stringBuilder.append(lowerNibbleToASCIIHexDigit(randomValues[i]));
         stringBuilder.append(upperNibbleToASCIIHexDigit(randomValues[i]));
     }
     return stringBuilder.toString();
 }
@@ skipping 54 matching lines @@
 PassRefPtr<SharedBuffer> MHTMLArchive::generateMHTMLData(const Vector<SerializedResource>& resources, EncodingPolicy encodingPolicy, const String& title, const String& mimeType)
 {
     String boundary = generateRandomBoundary();
     String endOfResourceBoundary = "--" + boundary + "\r\n";
 
     DateComponents now;
     now.setMillisecondsSinceEpochForDateTime(currentTimeMS());
     String dateString = makeRFC2822DateString(now.weekDay(), now.monthDay(), now.month(), now.fullYear(), now.hour(), now.minute(), now.second(), 0);
 
     StringBuilder stringBuilder;
-    stringBuilder.append("From: <Saved by WebKit>\r\n");
-    stringBuilder.append("Subject: ");
+    stringBuilder.appendLiteral("From: <Saved by WebKit>\r\n");
+    stringBuilder.appendLiteral("Subject: ");
     // We replace non ASCII characters with '?' characters to match IE's behavior.
     stringBuilder.append(replaceNonPrintableCharacters(title));
-    stringBuilder.append("\r\nDate: ");
+    stringBuilder.appendLiteral("\r\nDate: ");
     stringBuilder.append(dateString);
-    stringBuilder.append("\r\nMIME-Version: 1.0\r\n");
-    stringBuilder.append("Content-Type: multipart/related;\r\n");
-    stringBuilder.append("\ttype=\"");
+    stringBuilder.appendLiteral("\r\nMIME-Version: 1.0\r\n");
+    stringBuilder.appendLiteral("Content-Type: multipart/related;\r\n");
+    stringBuilder.appendLiteral("\ttype=\"");
     stringBuilder.append(mimeType);
-    stringBuilder.append("\";\r\n");
-    stringBuilder.append("\tboundary=\"");
+    stringBuilder.appendLiteral("\";\r\n");
+    stringBuilder.appendLiteral("\tboundary=\"");
     stringBuilder.append(boundary);
-    stringBuilder.append("\"\r\n\r\n");
+    stringBuilder.appendLiteral("\"\r\n\r\n");
 
     // We use utf8() below instead of ascii() as ascii() replaces CRLFs with ?? (we still only have put ASCII characters in it).
     ASSERT(stringBuilder.toString().containsOnlyASCII());
     CString asciiString = stringBuilder.toString().utf8();
     RefPtr<SharedBuffer> mhtmlData = SharedBuffer::create();
     mhtmlData->append(asciiString.data(), asciiString.length());
 
     for (size_t i = 0; i < resources.size(); ++i) {
         const SerializedResource& resource = resources[i];
 
         stringBuilder.clear();
         stringBuilder.append(endOfResourceBoundary);
-        stringBuilder.append("Content-Type: ");
+        stringBuilder.appendLiteral("Content-Type: ");
         stringBuilder.append(resource.mimeType);
 
         const char* contentEncoding = 0;
         if (encodingPolicy == UseBinaryEncoding)
             contentEncoding = binary;
         else if (MIMETypeRegistry::isSupportedJavaScriptMIMEType(resource.mimeType) || MIMETypeRegistry::isSupportedNonImageMIMEType(resource.mimeType))
             contentEncoding = quotedPrintable;
         else
             contentEncoding = base64;
 
-        stringBuilder.append("\r\nContent-Transfer-Encoding: ");
+        stringBuilder.appendLiteral("\r\nContent-Transfer-Encoding: ");
         stringBuilder.append(contentEncoding);
-        stringBuilder.append("\r\nContent-Location: ");
+        stringBuilder.appendLiteral("\r\nContent-Location: ");
         stringBuilder.append(resource.url);
-        stringBuilder.append("\r\n\r\n");
+        stringBuilder.appendLiteral("\r\n\r\n");
 
         asciiString = stringBuilder.toString().utf8();
         mhtmlData->append(asciiString.data(), asciiString.length());
 
         if (!strcmp(contentEncoding, binary)) {
             const char* data;
             size_t position = 0;
             while (size_t length = resource.data->getSomeData(data, position)) {
                 mhtmlData->append(data, length);
                 position += length;
@@ skipping 65 matching lines @@
 }
 
 void MHTMLArchive::trace(Visitor* visitor)
 {
     visitor->trace(m_mainResource);
     visitor->trace(m_subresources);
     visitor->trace(m_subframeArchives);
 }
 
 }