Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/platform/text/DateTimeFormat.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/platform/network/ProxyServer.cpp ('k') | Source/platform/text/LocaleWin.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 { 249 {
250 if (literal.length() <= 0) 250 if (literal.length() <= 0)
251 return; 251 return;
252 252
253 if (literal.find(isASCIIAlphabetOrQuote) == kNotFound) { 253 if (literal.find(isASCIIAlphabetOrQuote) == kNotFound) {
254 buffer.append(literal); 254 buffer.append(literal);
255 return; 255 return;
256 } 256 }
257 257
258 if (literal.find('\'') == kNotFound) { 258 if (literal.find('\'') == kNotFound) {
259 buffer.append("'"); 259 buffer.append('\'');
260 buffer.append(literal); 260 buffer.append(literal);
261 buffer.append("'"); 261 buffer.append('\'');
262 return; 262 return;
263 } 263 }
264 264
265 for (unsigned i = 0; i < literal.length(); ++i) { 265 for (unsigned i = 0; i < literal.length(); ++i) {
266 if (literal[i] == '\'') { 266 if (literal[i] == '\'') {
267 buffer.append("''"); 267 buffer.appendLiteral("''");
268 } else { 268 } else {
269 String escaped = literal.substring(i); 269 String escaped = literal.substring(i);
270 escaped.replace("'", "''"); 270 escaped.replace("'", "''");
271 buffer.append("'"); 271 buffer.append('\'');
272 buffer.append(escaped); 272 buffer.append(escaped);
273 buffer.append("'"); 273 buffer.append('\'');
274 return; 274 return;
275 } 275 }
276 } 276 }
277 } 277 }
278 278
279 } // namespace blink 279 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/network/ProxyServer.cpp ('k') | Source/platform/text/LocaleWin.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698