Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: Source/core/html/forms/FormController.cpp

Issue 482753002: Use StringBuilder::appendLiteral() / StringBuilder::append(char) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/forms/EmailInputType.cpp ('k') | Source/core/html/forms/ImageInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/FormController.cpp
diff --git a/Source/core/html/forms/FormController.cpp b/Source/core/html/forms/FormController.cpp
index afcc35577619b7d8fdeabdd16431fbd18d06030f..046e0b231cddc92ae26ee7a6a2374729ace996e9 100644
--- a/Source/core/html/forms/FormController.cpp
+++ b/Source/core/html/forms/FormController.cpp
@@ -317,7 +317,7 @@ static inline void recordFormStructure(const HTMLFormElement& form, StringBuilde
// 2 is enough to distinguish forms in webkit.org/b/91209#c0
const size_t namedControlsToBeRecorded = 2;
const FormAssociatedElement::List& controls = form.associatedElements();
- builder.append(" [");
+ builder.appendLiteral(" [");
for (size_t i = 0, namedControls = 0; i < controls.size() && namedControls < namedControlsToBeRecorded; ++i) {
if (!controls[i]->isFormControlElementWithState())
continue;
@@ -329,9 +329,9 @@ static inline void recordFormStructure(const HTMLFormElement& form, StringBuilde
continue;
namedControls++;
builder.append(name);
- builder.append(" ");
+ builder.append(' ');
}
- builder.append("]");
+ builder.append(']');
}
static inline String formSignature(const HTMLFormElement& form)
« no previous file with comments | « Source/core/html/forms/EmailInputType.cpp ('k') | Source/core/html/forms/ImageInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698