Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 426233002: Land the Fan (disabled) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by danno
Modified:
2 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review feedback, rebase and "git cl format" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69205 lines, -2624 lines) Patch
M build/toolchain.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M include/v8.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.h View 1 3 chunks +32 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 1 6 chunks +38 lines, -8 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 22 chunks +86 lines, -52 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 2 chunks +25 lines, -23 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 19 chunks +62 lines, -46 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/simulator-arm64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/arm64/utils-arm64.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast.h View 1 4 chunks +15 lines, -1 line 0 comments Download
M src/base/logging.h View 1 2 chunks +0 lines, -44 lines 0 comments Download
M src/bootstrapper.cc View 1 5 chunks +62 lines, -22 lines 0 comments Download
M src/checks.h View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/checks.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 8 chunks +19 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 1 10 chunks +17 lines, -24 lines 0 comments Download
M src/compiler.h View 1 2 chunks +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 7 chunks +45 lines, -10 lines 0 comments Download
M src/compiler-intrinsics.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/arm/code-generator-arm.cc View 1 1 chunk +828 lines, -0 lines 0 comments Download
A src/compiler/arm/instruction-codes-arm.h View 1 1 chunk +84 lines, -0 lines 0 comments Download
A src/compiler/arm/instruction-selector-arm.cc View 1 1 chunk +796 lines, -0 lines 0 comments Download
A src/compiler/arm/linkage-arm.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download
A src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +825 lines, -0 lines 0 comments Download
A src/compiler/arm64/instruction-codes-arm64.h View 1 1 chunk +101 lines, -0 lines 0 comments Download
A src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +606 lines, -0 lines 0 comments Download
A src/compiler/arm64/linkage-arm64.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download
A src/compiler/ast-graph-builder.h View 1 1 chunk +417 lines, -0 lines 0 comments Download
A src/compiler/ast-graph-builder.cc View 1 1 chunk +1990 lines, -0 lines 0 comments Download
A src/compiler/code-generator.h View 1 1 chunk +144 lines, -0 lines 0 comments Download
A src/compiler/code-generator.cc View 1 1 chunk +288 lines, -0 lines 0 comments Download
A src/compiler/code-generator-impl.h View 1 1 chunk +130 lines, -0 lines 0 comments Download
A src/compiler/common-node-cache.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A src/compiler/common-operator.h View 1 1 chunk +285 lines, -0 lines 0 comments Download
A src/compiler/control-builders.h View 1 1 chunk +144 lines, -0 lines 0 comments Download
A src/compiler/control-builders.cc View 1 1 chunk +144 lines, -0 lines 0 comments Download
A src/compiler/frame.h View 1 1 chunk +104 lines, -0 lines 0 comments Download
A src/compiler/gap-resolver.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A src/compiler/gap-resolver.cc View 1 1 chunk +135 lines, -0 lines 0 comments Download
A src/compiler/generic-algorithm.h View 1 1 chunk +136 lines, -0 lines 0 comments Download
A src/compiler/generic-algorithm-inl.h View 1 1 chunk +48 lines, -0 lines 0 comments Download
A src/compiler/generic-graph.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A src/compiler/generic-node.h View 1 1 chunk +271 lines, -0 lines 0 comments Download
A src/compiler/generic-node-inl.h View 1 1 chunk +244 lines, -0 lines 0 comments Download
A src/compiler/graph.h View 1 1 chunk +97 lines, -0 lines 0 comments Download
A src/compiler/graph.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download
A src/compiler/graph-builder.h View 1 1 chunk +232 lines, -0 lines 0 comments Download
A src/compiler/graph-builder.cc View 1 1 chunk +253 lines, -0 lines 0 comments Download
A src/compiler/graph-inl.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
A src/compiler/graph-reducer.h View 1 1 chunk +77 lines, -0 lines 0 comments Download
A src/compiler/graph-reducer.cc View 1 1 chunk +94 lines, -0 lines 0 comments Download
A src/compiler/graph-replay.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A src/compiler/graph-replay.cc View 1 1 chunk +81 lines, -0 lines 0 comments Download
A src/compiler/graph-visualizer.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A src/compiler/graph-visualizer.cc View 1 1 chunk +260 lines, -0 lines 0 comments Download
A src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +929 lines, -0 lines 0 comments Download
A src/compiler/ia32/instruction-codes-ia32.h View 1 1 chunk +86 lines, -0 lines 0 comments Download
A src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +504 lines, -0 lines 0 comments Download
A src/compiler/ia32/linkage-ia32.cc View 1 1 chunk +62 lines, -0 lines 0 comments Download
A src/compiler/instruction.h View 1 1 chunk +843 lines, -0 lines 0 comments Download
A src/compiler/instruction.cc View 1 1 chunk +479 lines, -0 lines 0 comments Download
A src/compiler/instruction-codes.h View 1 1 chunk +114 lines, -0 lines 0 comments Download
A src/compiler/instruction-selector.h View 1 1 chunk +169 lines, -0 lines 0 comments Download
A src/compiler/instruction-selector.cc View 1 1 chunk +873 lines, -0 lines 0 comments Download
A src/compiler/instruction-selector-impl.h View 1 1 chunk +352 lines, -0 lines 0 comments Download
A + src/compiler/ir-operations.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A src/compiler/js-context-specialization.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A src/compiler/js-context-specialization.cc View 1 1 chunk +93 lines, -0 lines 0 comments Download
A src/compiler/js-generic-lowering.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A src/compiler/js-generic-lowering.cc View 1 1 chunk +425 lines, -0 lines 0 comments Download
A src/compiler/js-graph.h View 1 1 chunk +107 lines, -0 lines 0 comments Download
A src/compiler/js-graph.cc View 1 1 chunk +174 lines, -0 lines 0 comments Download
A src/compiler/js-operator.h View 1 1 chunk +204 lines, -0 lines 0 comments Download
A src/compiler/js-typed-lowering.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A src/compiler/js-typed-lowering.cc View 1 1 chunk +604 lines, -0 lines 0 comments Download
A src/compiler/linkage.h View 1 1 chunk +188 lines, -0 lines 0 comments Download
A src/compiler/linkage.cc View 1 1 chunk +140 lines, -0 lines 0 comments Download
A src/compiler/linkage-impl.h View 1 1 chunk +206 lines, -0 lines 0 comments Download
A src/compiler/lowering-builder.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A src/compiler/lowering-builder.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
A src/compiler/machine-node-factory.h View 1 1 chunk +367 lines, -0 lines 0 comments Download
A src/compiler/machine-operator.h View 1 1 chunk +177 lines, -0 lines 0 comments Download
A src/compiler/machine-operator-reducer.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
A src/compiler/machine-operator-reducer.cc View 1 1 chunk +343 lines, -0 lines 0 comments Download
A src/compiler/node.h View 1 1 chunk +92 lines, -0 lines 0 comments Download
A src/compiler/node.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
A src/compiler/node-aux-data.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A src/compiler/node-aux-data-inl.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
A src/compiler/node-cache.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A src/compiler/node-cache.cc View 1 1 chunk +120 lines, -0 lines 0 comments Download
A src/compiler/node-matchers.h View 1 1 chunk +133 lines, -0 lines 0 comments Download
A src/compiler/node-properties.h View 1 1 chunk +82 lines, -0 lines 0 comments Download
A src/compiler/node-properties-inl.h View 1 1 chunk +238 lines, -0 lines 0 comments Download
A src/compiler/opcodes.h View 1 1 chunk +294 lines, -0 lines 0 comments Download
A src/compiler/operator.h View 1 1 chunk +276 lines, -0 lines 0 comments Download
A src/compiler/operator-properties.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A src/compiler/operator-properties-inl.h View 1 1 chunk +101 lines, -0 lines 0 comments Download
A src/compiler/phi-reducer.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A src/compiler/pipeline.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A src/compiler/pipeline.cc View 1 1 chunk +290 lines, -0 lines 0 comments Download
A src/compiler/raw-machine-assembler.h View 1 1 chunk +130 lines, -0 lines 0 comments Download
A src/compiler/raw-machine-assembler.cc View 1 1 chunk +157 lines, -0 lines 0 comments Download
A + src/compiler/register-allocator.h View 1 22 chunks +116 lines, -203 lines 0 comments Download
A + src/compiler/register-allocator.cc View 1 68 chunks +606 lines, -651 lines 0 comments Download
A src/compiler/representation-change.h View 1 1 chunk +383 lines, -0 lines 0 comments Download
A src/compiler/schedule.h View 1 1 chunk +335 lines, -0 lines 0 comments Download
A src/compiler/schedule.cc View 1 1 chunk +92 lines, -0 lines 0 comments Download
A src/compiler/scheduler.h View 1 1 chunk +82 lines, -0 lines 0 comments Download
A src/compiler/scheduler.cc View 1 1 chunk +1065 lines, -0 lines 0 comments Download
A src/compiler/simplified-lowering.h View 1 1 chunk +60 lines, -0 lines 0 comments Download
A src/compiler/simplified-lowering.cc View 1 1 chunk +217 lines, -0 lines 0 comments Download
A src/compiler/simplified-node-factory.h View 1 1 chunk +128 lines, -0 lines 0 comments Download
A src/compiler/simplified-operator.h View 1 1 chunk +177 lines, -0 lines 0 comments Download
A src/compiler/source-position.h View 1 1 chunk +99 lines, -0 lines 0 comments Download
A src/compiler/source-position.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
A src/compiler/structured-machine-assembler.h View 1 1 chunk +312 lines, -0 lines 0 comments Download
A src/compiler/structured-machine-assembler.cc View 1 1 chunk +662 lines, -0 lines 0 comments Download
A src/compiler/typer.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A src/compiler/typer.cc View 1 1 chunk +842 lines, -0 lines 0 comments Download
A src/compiler/verifier.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A src/compiler/verifier.cc View 1 1 chunk +232 lines, -0 lines 0 comments Download
A src/compiler/x64/code-generator-x64.cc View 1 1 chunk +972 lines, -0 lines 0 comments Download
A src/compiler/x64/instruction-codes-x64.h View 1 1 chunk +106 lines, -0 lines 0 comments Download
A src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +666 lines, -0 lines 0 comments Download
A src/compiler/x64/linkage-x64.cc View 1 1 chunk +77 lines, -0 lines 0 comments Download
M src/contexts.h View 1 2 chunks +38 lines, -0 lines 0 comments Download
M src/contexts.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M src/data-flow.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 5 chunks +79 lines, -8 lines 0 comments Download
M src/elements-kind.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/field-index.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +18 lines, -0 lines 0 comments Download
M src/frames.cc View 1 4 chunks +19 lines, -4 lines 0 comments Download
M src/gdb-jit.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/globals.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 1 chunk +12 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 3 chunks +27 lines, -25 lines 0 comments Download
M src/hydrogen-gvn.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +1 line, -1 line 0 comments Download
M src/hydrogen-types.h View 1 2 chunks +1 line, -1 line 0 comments Download
M src/hydrogen-types.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 10 chunks +35 lines, -13 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 8 chunks +52 lines, -19 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 22 chunks +84 lines, -50 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 2 chunks +86 lines, -68 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 4 chunks +11 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/lithium.h View 1 5 chunks +60 lines, -6 lines 0 comments Download
M src/lithium.cc View 1 4 chunks +40 lines, -17 lines 0 comments Download
M src/lithium-allocator.h View 1 2 chunks +0 lines, -59 lines 0 comments Download
M src/lithium-allocator.cc View 1 1 chunk +1 line, -18 lines 0 comments Download
M src/lithium-allocator-inl.h View 1 1 chunk +0 lines, -87 lines 0 comments Download
A + src/lithium-inl.h View 1 5 chunks +18 lines, -52 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 17 chunks +51 lines, -44 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 17 chunks +33 lines, -44 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 15 chunks +99 lines, -58 lines 0 comments Download
M src/objects.cc View 1 6 chunks +34 lines, -14 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 3 chunks +33 lines, -3 lines 0 comments Download
M src/objects-printer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-visiting-inl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/parser.cc View 1 6 chunks +34 lines, -15 lines 0 comments Download
M src/property.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/property.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.h View 1 2 chunks +475 lines, -463 lines 0 comments Download
M src/runtime.cc View 1 14 chunks +572 lines, -45 lines 0 comments Download
M src/safepoint-table.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/scopeinfo.h View 1 4 chunks +23 lines, -22 lines 0 comments Download
M src/scopeinfo.cc View 1 8 chunks +37 lines, -23 lines 0 comments Download
M src/scopes.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
M src/scopes.cc View 1 7 chunks +24 lines, -24 lines 0 comments Download
M src/string-stream.cc View 1 1 chunk +12 lines, -3 lines 0 comments Download
M src/types.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/types.cc View 1 3 chunks +15 lines, -24 lines 0 comments Download
M src/typing.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/unique.h View 1 5 chunks +69 lines, -3 lines 0 comments Download
M src/v8.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M src/variables.h View 1 3 chunks +6 lines, -9 lines 0 comments Download
M src/variables.cc View 1 1 chunk +17 lines, -20 lines 0 comments Download
M src/x64/assembler-x64.h View 1 4 chunks +27 lines, -21 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 3 chunks +27 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 22 chunks +148 lines, -90 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 18 chunks +34 lines, -46 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/zone-allocator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/zone-containers.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/cctest.h View 1 4 chunks +37 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 3 chunks +41 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +94 lines, -0 lines 0 comments Download
A test/cctest/compiler/call-tester.h View 1 1 chunk +391 lines, -0 lines 0 comments Download
A test/cctest/compiler/codegen-tester.h View 1 1 chunk +323 lines, -0 lines 0 comments Download
A test/cctest/compiler/codegen-tester.cc View 1 1 chunk +578 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/call-tester.h View 1 1 chunk +391 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/codegen-tester.h View 1 1 chunk +323 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/codegen-tester.cc View 1 1 chunk +578 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/function-tester.h View 1 1 chunk +194 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/graph-builder-tester.h View 1 1 chunk +111 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/graph-builder-tester.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/graph-tester.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/instruction-selector-tester.h View 1 1 chunk +119 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/simplified-graph-builder.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/simplified-graph-builder.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-branch-combine.cc View 1 1 chunk +462 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-codegen-deopt.cc View 1 1 chunk +331 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-gap-resolver.cc View 1 1 chunk +172 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-graph-reducer.cc View 1 1 chunk +659 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-instruction.cc View 1 1 chunk +349 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-instruction-selector.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-instruction-selector-arm.cc View 1 1 chunk +977 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-js-constant-cache.cc View 1 1 chunk +284 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-js-context-specialization.cc View 1 1 chunk +252 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-js-typed-lowering.cc View 1 1 chunk +1345 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-linkage.cc View 1 1 chunk +113 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-machine-operator-reducer.cc View 1 1 chunk +776 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-node.cc View 1 1 chunk +813 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-node-algorithm.cc View 1 1 chunk +330 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-node-cache.cc View 1 1 chunk +160 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-operator.cc View 1 1 chunk +244 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-phi-reducer.cc View 1 1 chunk +223 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-pipeline.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-representation-change.cc View 1 1 chunk +281 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-deopt.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-intrinsics.cc View 1 1 chunk +211 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-jsbranches.cc View 1 1 chunk +262 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-jscalls.cc View 1 1 chunk +235 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-jsexceptions.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-jsops.cc View 1 1 chunk +524 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-machops.cc View 1 1 chunk +3798 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-run-variables.cc View 1 1 chunk +121 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-schedule.cc View 1 1 chunk +159 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-scheduler.cc View 1 1 chunk +1840 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-simplified-lowering.cc View 1 1 chunk +614 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-structured-ifbuilder-fuzzer.cc View 1 1 chunk +666 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/test-structured-machine-assembler.cc View 1 1 chunk +1055 lines, -0 lines 0 comments Download
A test/cctest/compiler/compiler/value-helper.h View 1 1 chunk +122 lines, -0 lines 0 comments Download
A test/cctest/compiler/function-tester.h View 1 1 chunk +194 lines, -0 lines 0 comments Download
A test/cctest/compiler/graph-builder-tester.h View 1 1 chunk +111 lines, -0 lines 0 comments Download
A test/cctest/compiler/graph-builder-tester.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
A test/cctest/compiler/graph-tester.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A test/cctest/compiler/instruction-selector-tester.h View 1 1 chunk +119 lines, -0 lines 0 comments Download
A test/cctest/compiler/simplified-graph-builder.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
A test/cctest/compiler/simplified-graph-builder.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-branch-combine.cc View 1 1 chunk +462 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-codegen-deopt.cc View 1 1 chunk +331 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-gap-resolver.cc View 1 1 chunk +172 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-graph-reducer.cc View 1 1 chunk +659 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-instruction.cc View 1 1 chunk +349 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-instruction-selector.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-instruction-selector-arm.cc View 1 1 chunk +977 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-js-constant-cache.cc View 1 1 chunk +284 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-js-context-specialization.cc View 1 1 chunk +252 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-js-typed-lowering.cc View 1 1 chunk +1345 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-linkage.cc View 1 1 chunk +113 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-machine-operator-reducer.cc View 1 1 chunk +776 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-node.cc View 1 1 chunk +813 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-node-algorithm.cc View 1 1 chunk +330 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-node-cache.cc View 1 1 chunk +160 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-operator.cc View 1 1 chunk +244 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-phi-reducer.cc View 1 1 chunk +223 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-pipeline.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-representation-change.cc View 1 1 chunk +281 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-deopt.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-intrinsics.cc View 1 1 chunk +211 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-jsbranches.cc View 1 1 chunk +262 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-jscalls.cc View 1 1 chunk +235 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-jsexceptions.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-jsops.cc View 1 1 chunk +524 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-machops.cc View 1 1 chunk +3798 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-run-variables.cc View 1 1 chunk +121 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-schedule.cc View 1 1 chunk +159 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-scheduler.cc View 1 1 chunk +1840 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-simplified-lowering.cc View 1 1 chunk +614 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-structured-ifbuilder-fuzzer.cc View 1 1 chunk +666 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-structured-machine-assembler.cc View 1 1 chunk +1055 lines, -0 lines 0 comments Download
A test/cctest/compiler/value-helper.h View 1 1 chunk +122 lines, -0 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-checks.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 4 chunks +24 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 4 chunks +208 lines, -30 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/fuzz-natives/fuzz-natives.status View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/assert-opt-and-deopt.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +111 lines, -0 lines 0 comments Download
D test/mjsunit/runtime-gen/classof.js View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 1 6 chunks +104 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM, modulo the src/compiler/compiler directory as discussed. https://codereview.chromium.org/426233002/diff/1/src/lithium-inl.h File src/lithium-inl.h (right): https://codereview.chromium.org/426233002/diff/1/src/lithium-inl.h#newcode6 src/lithium-inl.h:6: // * ...
2 years, 11 months ago (2014-07-30 13:03:04 UTC) #1
danno
2 years, 11 months ago (2014-07-30 13:57:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r22709 (tree was closed).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589