src/arm/macro-assembler-arm.cc - Issue 426233002: Land the Fan (disabled)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/macro-assembler-arm.cc

Issue 426233002: Land the Fan (disabled) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback, rebase and "git cl format" Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/macro-assembler-arm.cc

diff --git a/src/arm/macro-assembler-arm.cc b/src/arm/macro-assembler-arm.cc

index 7ce3112f8a361e5d0f4fbaa0e3f74065d026a92d..c1b34053758172ad731953ddbbeb25794adbc6da 100644

--- a/src/arm/macro-assembler-arm.cc

+++ b/src/arm/macro-assembler-arm.cc

@@ -254,7 +254,7 @@ void MacroAssembler::Mls(Register dst, Register src1, Register src2,

CpuFeatureScope scope(this, MLS);

mls(dst, src1, src2, srcA, cond);

} else {

- ASSERT(!dst.is(srcA));

+ ASSERT(!srcA.is(ip));

mul(ip, src1, src2, LeaveCC, cond);

sub(dst, srcA, ip, LeaveCC, cond);

}

« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | src/arm/simulator-arm.cc » ('j') | no next file with comments »