Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385713005: Allow GrGLEffects to produce variable length keys. (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@key
Visibility:
Public.

Description

Allow GrGLEffects to produce variable length keys. Committed: https://skia.googlesource.com/skia/+/63e99f7a03b2ac90ae7a00232674fd39c0bdcc68

Patch Set 1 #

Patch Set 2 : minor edits #

Patch Set 3 : update #

Patch Set 4 : cleanup #

Total comments: 2

Patch Set 5 : fix typo #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -384 lines) Patch
M include/gpu/GrBackendEffectFactory.h View 1 2 3 2 chunks +25 lines, -2 lines 0 comments Download
M include/gpu/GrEffect.h View 1 chunk +2 lines, -3 lines 0 comments Download
M include/gpu/GrTBackendEffectFactory.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 4 chunks +3 lines, -7 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 2 3 2 chunks +29 lines, -27 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 20 chunks +49 lines, -59 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 4 chunks +11 lines, -17 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 4 chunks +4 lines, -8 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +14 lines, -12 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +21 lines, -15 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 2 3 6 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 4 chunks +8 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLEffect.h View 4 chunks +6 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 1 2 8 chunks +11 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 1 2 13 chunks +20 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bsalomon
Depends on https://codereview.chromium.org/379113004/ landing.
6 years, 5 months ago (2014-07-11 20:29:21 UTC) #1
bsalomon
I accidentally sent this to robertphillips@googlel.com the first time :)
6 years, 5 months ago (2014-07-12 04:44:25 UTC) #2
robertphillips
lgtm + 1 typo fixup https://codereview.chromium.org/385713005/diff/60001/src/gpu/gl/GrGLProgramDesc.h File src/gpu/gl/GrGLProgramDesc.h (right): https://codereview.chromium.org/385713005/diff/60001/src/gpu/gl/GrGLProgramDesc.h#newcode232 src/gpu/gl/GrGLProgramDesc.h:232: uint16_t length = offsetsAndLengths[2 ...
6 years, 5 months ago (2014-07-13 16:36:48 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-17 15:19:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/385713005/80001
6 years, 5 months ago (2014-07-17 15:20:02 UTC) #5
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 5 months ago (2014-07-17 15:26:46 UTC) #6
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-21 14:51:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/385713005/100001
6 years, 5 months ago (2014-07-21 14:51:50 UTC) #8
bsalomon
https://codereview.chromium.org/385713005/diff/60001/src/gpu/gl/GrGLProgramDesc.h File src/gpu/gl/GrGLProgramDesc.h (right): https://codereview.chromium.org/385713005/diff/60001/src/gpu/gl/GrGLProgramDesc.h#newcode232 src/gpu/gl/GrGLProgramDesc.h:232: uint16_t length = offsetsAndLengths[2 * (fBaseIndex + index) + ...
6 years, 5 months ago (2014-07-21 14:51:59 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 15:03:20 UTC) #10
Message was sent while issue was closed. 
Change committed as 63e99f7a03b2ac90ae7a00232674fd39c0bdcc68

Powered by Google App Engine
This is Rietveld 408576698