Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Position::AfterNode() to take const Node& instead of Node* This patch makes |Position::AfterNode()| to take |const Node&| instead of |Node*| since |Node| parameter can not be nullptr for improving code health. This patch is a preparation of make |Position| to hold |const Node&|[1] and similar to the patch[2] which change |BeforeNode()|. [1] http://crbug.com/735327 Position should hold const Node instead of Node [2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node& instead of Node* BUG=734849 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2953683004 Cr-Commit-Position: refs/heads/master@{#481450} Committed: https://chromium.googlesource.com/chromium/src/+/1eeccaf7268c04ca0f50c076c9ac827167b6735a

Patch Set 1 : 2017-06-22T12:37:16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -75 lines) Patch
M third_party/WebKit/Source/core/dom/RangeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp View 12 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionTest.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
yosin_UTC9
PTAL Including core/dom/RangeTest.cpp and core/editing/
3 years, 6 months ago (2017-06-22 04:53:56 UTC) #5
tkent
lgtm
3 years, 6 months ago (2017-06-22 04:58:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953683004/1
3 years, 6 months ago (2017-06-22 05:01:05 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 05:34:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1eeccaf7268c04ca0f50c076c9ac...

Powered by Google App Engine
This is Rietveld 408576698