Make Position::AfterNode() to take const Node& instead of Node*
This patch makes |Position::AfterNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2953683004
Cr-Commit-Position: refs/heads/master@{#481450}
Committed: https://chromium.googlesource.com/chromium/src/+/1eeccaf7268c04ca0f50c076c9ac827167b6735a
Description was changed from ========== 2017-06-22T12:37:16 BUG= 2017-06-22T12:36:39 ========== to ========== Make Position::AfterNode() to take ...
3 years, 6 months ago
(2017-06-22 03:40:13 UTC)
#1
Description was changed from
==========
2017-06-22T12:37:16
BUG=
2017-06-22T12:36:39
==========
to
==========
Make Position::AfterNode() to take const Node& instead of Node*
This patch makes |Position::AfterNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
==========
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 6 months ago
(2017-06-22 03:40:19 UTC)
#2
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1498107646713220, "parent_rev": "aa449b76a4ea265126b7c3bdd5084589e5b66adf", "commit_rev": "1eeccaf7268c04ca0f50c076c9ac827167b6735a"}
3 years, 6 months ago
(2017-06-22 05:34:23 UTC)
#10
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498107646713220, "parent_rev":
"aa449b76a4ea265126b7c3bdd5084589e5b66adf", "commit_rev":
"1eeccaf7268c04ca0f50c076c9ac827167b6735a"}
commit-bot: I haz the power
Description was changed from ========== Make Position::AfterNode() to take const Node& instead of Node* This ...
3 years, 6 months ago
(2017-06-22 05:34:38 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
Make Position::AfterNode() to take const Node& instead of Node*
This patch makes |Position::AfterNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
==========
to
==========
Make Position::AfterNode() to take const Node& instead of Node*
This patch makes |Position::AfterNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2953683004
Cr-Commit-Position: refs/heads/master@{#481450}
Committed:
https://chromium.googlesource.com/chromium/src/+/1eeccaf7268c04ca0f50c076c9ac...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1eeccaf7268c04ca0f50c076c9ac827167b6735a
3 years, 6 months ago
(2017-06-22 05:34:39 UTC)
#12
Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node*
(Closed)
Created 3 years, 6 months ago by yosin_UTC9
Modified 3 years, 6 months ago
Reviewers: tkent
Base URL:
Comments: 0