Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 2fda8a658c9f07c5bfa8724acecfd971a49fc38c..8c81961df3e70d225ecf13c5623bcf547f9503d2 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -323,7 +323,7 @@ static PositionTemplate<Strategy> PreviousBoundaryAlgorithm(
ForwardsTextBuffer suffix_string;
if (RequiresContextForWordBoundary(CharacterBefore(c))) {
TextIteratorAlgorithm<Strategy> forwards_iterator(
- end, PositionTemplate<Strategy>::AfterNode(boundary));
+ end, PositionTemplate<Strategy>::AfterNode(*boundary));
while (!forwards_iterator.AtEnd()) {
forwards_iterator.CopyTextTo(&suffix_string);
int context_end_index = EndOfFirstWordBoundaryContext(
@@ -1386,7 +1386,7 @@ static PositionTemplate<Strategy> MostBackwardCaretPosition(
if (EditingIgnoresContent(*current_node) ||
IsDisplayInsideTable(current_node)) {
if (current_pos.AtEndOfNode())
- return PositionTemplate<Strategy>::AfterNode(current_node);
+ return PositionTemplate<Strategy>::AfterNode(*current_node);
continue;
}

Powered by Google App Engine
This is Rietveld 408576698