Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.cpp
diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp
index 7d79cdf3ad66559c1f13b5b7028c6c858d0dbaed..6b58eb430417d009ca5569b0c701b265a1a73bdf 100644
--- a/third_party/WebKit/Source/core/editing/Position.cpp
+++ b/third_party/WebKit/Source/core/editing/Position.cpp
@@ -474,9 +474,8 @@ PositionTemplate<Strategy> PositionTemplate<Strategy>::BeforeNode(
// static
template <typename Strategy>
PositionTemplate<Strategy> PositionTemplate<Strategy>::AfterNode(
- Node* anchor_node) {
- DCHECK(anchor_node);
- return PositionTemplate<Strategy>(anchor_node,
+ const Node& anchor_node) {
+ return PositionTemplate<Strategy>(&anchor_node,
PositionAnchorType::kAfterAnchor);
}
@@ -525,7 +524,7 @@ PositionTemplate<Strategy>
PositionTemplate<Strategy>::LastPositionInOrAfterNode(Node* node) {
if (!node)
return PositionTemplate<Strategy>();
- return EditingIgnoresContent(*node) ? AfterNode(node)
+ return EditingIgnoresContent(*node) ? AfterNode(*node)
: LastPositionInNode(node);
}
@@ -597,7 +596,7 @@ Position ToPositionInDOMTree(const PositionInFlatTree& position) {
// FIXME: When anchorNode is <img>, assertion fails in the constructor.
return Position(anchor_node, PositionAnchorType::kAfterChildren);
case PositionAnchorType::kAfterAnchor:
- return Position::AfterNode(anchor_node);
+ return Position::AfterNode(*anchor_node);
case PositionAnchorType::kBeforeChildren:
return Position(anchor_node, PositionAnchorType::kBeforeChildren);
case PositionAnchorType::kBeforeAnchor:
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.h ('k') | third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698