third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp - Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

index d7b4419d7256b5d043d4add47a3f50f2603a3b1c..3a7f22ca9eda1a0fea0c744a5b5a4a42dd52d6b3 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

@@ -913,7 +913,7 @@ void TypingCommand::ForwardDeleteKeyPressed(TextGranularity granularity,

SelectionInDOMTree::Builder()

.SetBaseAndExtentDeprecated(

EndingSelection().End(),

- Position::AfterNode(downstream_end.ComputeContainerNode()))

+ Position::AfterNode(*downstream_end.ComputeContainerNode()))

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

TypingAddedToOpenCommand(kForwardDeleteKey);