third_party/WebKit/Source/core/editing/serializers/Serialization.cpp - Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

index 22c3ba11b3ef1d034e2d74af2f4913c41306e4b1..3f628d20a30dd0e349e91ec2dd0e2977b7108295 100644

--- a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

@@ -410,7 +410,7 @@ DocumentFragment* CreateFragmentFromMarkupWithContext(

tagged_document->AppendChild(root);

const EphemeralRange range(

- Position::AfterNode(node_before_context).ParentAnchoredEquivalent(),

+ Position::AfterNode(*node_before_context).ParentAnchoredEquivalent(),

Position::BeforeNode(*node_after_context).ParentAnchoredEquivalent());

Node* common_ancestor = range.CommonAncestorContainer();

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | no next file » | no next file with comments »