Make Position::AfterNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/PositionTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/Position.h"
 
 #include "core/editing/EditingTestBase.h"
 
 namespace blink {
 
 class PositionTest : public EditingTestBase {};
 
 TEST_F(PositionTest, IsEquivalent) {
   SetBodyContent("<a id=sample>0<b>1</b>2</a>");
 
   Element* sample = GetDocument().getElementById("sample");
 
   EXPECT_TRUE(Position(sample, 0).IsEquivalent(Position(sample, 0)));
 
   EXPECT_TRUE(
       Position(sample, 0).IsEquivalent(Position::FirstPositionInNode(sample)));
   EXPECT_TRUE(Position(sample, 0).IsEquivalent(
       Position::BeforeNode(*sample->firstChild())));
   EXPECT_TRUE(Position(sample, 1).IsEquivalent(
-      Position::AfterNode(sample->firstChild())));
+      Position::AfterNode(*sample->firstChild())));
   EXPECT_TRUE(Position(sample, 1).IsEquivalent(
       Position::BeforeNode(*sample->firstChild()->nextSibling())));
   EXPECT_TRUE(Position(sample, 2).IsEquivalent(
       Position::BeforeNode(*sample->lastChild())));
   EXPECT_TRUE(Position(sample, 3).IsEquivalent(
-      Position::AfterNode(sample->lastChild())));
+      Position::AfterNode(*sample->lastChild())));
   EXPECT_TRUE(
       Position(sample, 3).IsEquivalent(Position::LastPositionInNode(sample)));
 
   EXPECT_FALSE(Position(sample, 0).IsEquivalent(Position(sample, 1)));
   EXPECT_FALSE(
       Position(sample, 0).IsEquivalent(Position::LastPositionInNode(sample)));
 }
 
 TEST_F(PositionTest, NodeAsRangeLastNodeNull) {
   EXPECT_EQ(nullptr, Position().NodeAsRangeLastNode());
   EXPECT_EQ(nullptr, PositionInFlatTree().NodeAsRangeLastNode());
 }
 
 TEST_F(PositionTest, editingPositionOfWithEditingIgnoresContent) {
   const char* body_content =
       "<textarea id=textarea></textarea><a id=child1>1</a><b id=child2>2</b>";
   SetBodyContent(body_content);
   Node* textarea = GetDocument().getElementById("textarea");
 
   EXPECT_EQ(Position::BeforeNode(*textarea),
             Position::EditingPositionOf(textarea, 0));
-  EXPECT_EQ(Position::AfterNode(textarea),
+  EXPECT_EQ(Position::AfterNode(*textarea),
             Position::EditingPositionOf(textarea, 1));
-  EXPECT_EQ(Position::AfterNode(textarea),
+  EXPECT_EQ(Position::AfterNode(*textarea),
             Position::EditingPositionOf(textarea, 2));
 
   // Change DOM tree to
   // <textarea id=textarea><a id=child1>1</a><b id=child2>2</b></textarea>
   Node* child1 = GetDocument().getElementById("child1");
   Node* child2 = GetDocument().getElementById("child2");
   textarea->appendChild(child1);
   textarea->appendChild(child2);
 
   EXPECT_EQ(Position::BeforeNode(*textarea),
             Position::EditingPositionOf(textarea, 0));
-  EXPECT_EQ(Position::AfterNode(textarea),
+  EXPECT_EQ(Position::AfterNode(*textarea),
             Position::EditingPositionOf(textarea, 1));
-  EXPECT_EQ(Position::AfterNode(textarea),
+  EXPECT_EQ(Position::AfterNode(*textarea),
             Position::EditingPositionOf(textarea, 2));
-  EXPECT_EQ(Position::AfterNode(textarea),
+  EXPECT_EQ(Position::AfterNode(*textarea),
             Position::EditingPositionOf(textarea, 3));
 }
 
 TEST_F(PositionTest, NodeAsRangeLastNode) {
   const char* body_content =
       "<p id='p1'>11</p><p id='p2'></p><p id='p3'>33</p>";
   SetBodyContent(body_content);
   Node* p1 = GetDocument().getElementById("p1");
   Node* p2 = GetDocument().getElementById("p2");
   Node* p3 = GetDocument().getElementById("p3");
   Node* body = EditingStrategy::Parent(*p1);
   Node* t1 = EditingStrategy::FirstChild(*p1);
   Node* t3 = EditingStrategy::FirstChild(*p3);
 
   EXPECT_EQ(body, Position::InParentBeforeNode(*p1).NodeAsRangeLastNode());
   EXPECT_EQ(t1, Position::InParentBeforeNode(*p2).NodeAsRangeLastNode());
   EXPECT_EQ(p2, Position::InParentBeforeNode(*p3).NodeAsRangeLastNode());
   EXPECT_EQ(t1, Position::InParentAfterNode(*p1).NodeAsRangeLastNode());
   EXPECT_EQ(p2, Position::InParentAfterNode(*p2).NodeAsRangeLastNode());
   EXPECT_EQ(t3, Position::InParentAfterNode(*p3).NodeAsRangeLastNode());
-  EXPECT_EQ(t3, Position::AfterNode(p3).NodeAsRangeLastNode());
+  EXPECT_EQ(t3, Position::AfterNode(*p3).NodeAsRangeLastNode());
 
   EXPECT_EQ(body,
             PositionInFlatTree::InParentBeforeNode(*p1).NodeAsRangeLastNode());
   EXPECT_EQ(t1,
             PositionInFlatTree::InParentBeforeNode(*p2).NodeAsRangeLastNode());
   EXPECT_EQ(p2,
             PositionInFlatTree::InParentBeforeNode(*p3).NodeAsRangeLastNode());
   EXPECT_EQ(t1,
             PositionInFlatTree::InParentAfterNode(*p1).NodeAsRangeLastNode());
   EXPECT_EQ(p2,
             PositionInFlatTree::InParentAfterNode(*p2).NodeAsRangeLastNode());
   EXPECT_EQ(t3,
             PositionInFlatTree::InParentAfterNode(*p3).NodeAsRangeLastNode());
-  EXPECT_EQ(t3, PositionInFlatTree::AfterNode(p3).NodeAsRangeLastNode());
+  EXPECT_EQ(t3, PositionInFlatTree::AfterNode(*p3).NodeAsRangeLastNode());
 }
 
 TEST_F(PositionTest, NodeAsRangeLastNodeShadow) {
   const char* body_content =
       "<p id='host'>00<b id='one'>11</b><b id='two'>22</b>33</p>";
   const char* shadow_content =
       "<a id='a'><content select=#two></content><content "
       "select=#one></content></a>";
   SetBodyContent(body_content);
   ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
 
   Node* host = GetDocument().getElementById("host");
   Node* n1 = GetDocument().getElementById("one");
   Node* n2 = GetDocument().getElementById("two");
   Node* t0 = EditingStrategy::FirstChild(*host);
   Node* t1 = EditingStrategy::FirstChild(*n1);
   Node* t2 = EditingStrategy::FirstChild(*n2);
   Node* t3 = EditingStrategy::LastChild(*host);
   Node* a = shadow_root->getElementById("a");
 
   EXPECT_EQ(t0, Position::InParentBeforeNode(*n1).NodeAsRangeLastNode());
   EXPECT_EQ(t1, Position::InParentBeforeNode(*n2).NodeAsRangeLastNode());
   EXPECT_EQ(t1, Position::InParentAfterNode(*n1).NodeAsRangeLastNode());
   EXPECT_EQ(t2, Position::InParentAfterNode(*n2).NodeAsRangeLastNode());
-  EXPECT_EQ(t3, Position::AfterNode(host).NodeAsRangeLastNode());
+  EXPECT_EQ(t3, Position::AfterNode(*host).NodeAsRangeLastNode());
 
   EXPECT_EQ(t2,
             PositionInFlatTree::InParentBeforeNode(*n1).NodeAsRangeLastNode());
   EXPECT_EQ(a,
             PositionInFlatTree::InParentBeforeNode(*n2).NodeAsRangeLastNode());
   EXPECT_EQ(t1,
             PositionInFlatTree::InParentAfterNode(*n1).NodeAsRangeLastNode());
   EXPECT_EQ(t2,
             PositionInFlatTree::InParentAfterNode(*n2).NodeAsRangeLastNode());
-  EXPECT_EQ(t1, PositionInFlatTree::AfterNode(host).NodeAsRangeLastNode());
+  EXPECT_EQ(t1, PositionInFlatTree::AfterNode(*host).NodeAsRangeLastNode());
 }
 
 TEST_F(PositionTest, ToPositionInFlatTreeWithActiveInsertionPoint) {
   const char* body_content = "<p id='host'>00<b id='one'>11</b>22</p>";
   const char* shadow_content =
       "<a id='a'><content select=#one "
       "id='content'></content><content></content></a>";
   SetBodyContent(body_content);
   ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
   Element* anchor = shadow_root->getElementById("a");
@@ skipping 70 matching lines @@
   const char* shadow_content = "";
   SetBodyContent(body_content);
   ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
   Element* host = GetDocument().getElementById("host");
 
   EXPECT_EQ(PositionInFlatTree(host, PositionAnchorType::kAfterChildren),
             ToPositionInFlatTree(Position(shadow_root, 0)));
 }
 
 }  // namespace blink