Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.cpp ('k') | third_party/WebKit/Source/core/editing/PositionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
index fe63644301e54415092b7d5de2267bb756e686ce..615d2aea52b2f82e25da7b773e68715acd9963f6 100644
--- a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
+++ b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
@@ -23,7 +23,7 @@ TEST_F(PositionIteratorTest, decrementWithInputElement) {
EXPECT_EQ(Position::LastPositionInNode(GetDocument().body()),
dom_iterator.ComputePosition());
dom_iterator.Decrement();
- EXPECT_EQ(Position::AfterNode(input), dom_iterator.ComputePosition());
+ EXPECT_EQ(Position::AfterNode(*input), dom_iterator.ComputePosition());
dom_iterator.Decrement();
EXPECT_EQ(Position::BeforeNode(*input), dom_iterator.ComputePosition());
dom_iterator.Decrement();
@@ -37,7 +37,7 @@ TEST_F(PositionIteratorTest, decrementWithInputElement) {
EXPECT_EQ(PositionInFlatTree::LastPositionInNode(GetDocument().body()),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
- EXPECT_EQ(PositionInFlatTree::AfterNode(input),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*input),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
EXPECT_EQ(PositionInFlatTree::BeforeNode(*input),
@@ -60,9 +60,9 @@ TEST_F(PositionIteratorTest, decrementWithSelectElement) {
EXPECT_EQ(Position::LastPositionInNode(GetDocument().body()),
dom_iterator.ComputePosition());
dom_iterator.Decrement();
- EXPECT_EQ(Position::AfterNode(select), dom_iterator.ComputePosition());
+ EXPECT_EQ(Position::AfterNode(*select), dom_iterator.ComputePosition());
dom_iterator.Decrement();
- EXPECT_EQ(Position::AfterNode(select), dom_iterator.ComputePosition())
+ EXPECT_EQ(Position::AfterNode(*select), dom_iterator.ComputePosition())
<< "This is redundant result, we should not have. see "
"http://crbug.com/697283";
dom_iterator.Decrement();
@@ -78,10 +78,10 @@ TEST_F(PositionIteratorTest, decrementWithSelectElement) {
EXPECT_EQ(PositionInFlatTree::LastPositionInNode(GetDocument().body()),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
- EXPECT_EQ(PositionInFlatTree::AfterNode(select),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*select),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
- EXPECT_EQ(PositionInFlatTree::AfterNode(select),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*select),
flat_iterator.ComputePosition())
<< "This is redundant result, we should not have. see "
"http://crbug.com/697283";
@@ -107,7 +107,7 @@ TEST_F(PositionIteratorTest, decrementWithTextAreaElement) {
EXPECT_EQ(Position::LastPositionInNode(GetDocument().body()),
dom_iterator.ComputePosition());
dom_iterator.Decrement();
- EXPECT_EQ(Position::AfterNode(textarea), dom_iterator.ComputePosition());
+ EXPECT_EQ(Position::AfterNode(*textarea), dom_iterator.ComputePosition());
dom_iterator.Decrement();
EXPECT_EQ(Position::BeforeNode(*textarea), dom_iterator.ComputePosition());
dom_iterator.Decrement();
@@ -121,7 +121,7 @@ TEST_F(PositionIteratorTest, decrementWithTextAreaElement) {
EXPECT_EQ(PositionInFlatTree::LastPositionInNode(GetDocument().body()),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
- EXPECT_EQ(PositionInFlatTree::AfterNode(textarea),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*textarea),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
EXPECT_EQ(PositionInFlatTree::BeforeNode(*textarea),
@@ -146,7 +146,7 @@ TEST_F(PositionIteratorTest, incrementWithInputElement) {
dom_iterator.Increment();
EXPECT_EQ(Position::BeforeNode(*input), dom_iterator.ComputePosition());
dom_iterator.Increment();
- EXPECT_EQ(Position::AfterNode(input), dom_iterator.ComputePosition());
+ EXPECT_EQ(Position::AfterNode(*input), dom_iterator.ComputePosition());
dom_iterator.Increment();
EXPECT_EQ(Position(GetDocument().body(), 1), dom_iterator.ComputePosition());
dom_iterator.Increment();
@@ -161,7 +161,7 @@ TEST_F(PositionIteratorTest, incrementWithInputElement) {
EXPECT_EQ(PositionInFlatTree::BeforeNode(*input),
flat_iterator.ComputePosition());
flat_iterator.Increment();
- EXPECT_EQ(PositionInFlatTree::AfterNode(input),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*input),
flat_iterator.ComputePosition());
flat_iterator.Increment();
EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 1),
@@ -182,9 +182,9 @@ TEST_F(PositionIteratorTest, incrementWithSelectElement) {
dom_iterator.Increment();
EXPECT_EQ(Position::BeforeNode(*select), dom_iterator.ComputePosition());
dom_iterator.Increment();
- EXPECT_EQ(Position::AfterNode(select), dom_iterator.ComputePosition());
+ EXPECT_EQ(Position::AfterNode(*select), dom_iterator.ComputePosition());
dom_iterator.Increment();
- EXPECT_EQ(Position::AfterNode(select), dom_iterator.ComputePosition())
+ EXPECT_EQ(Position::AfterNode(*select), dom_iterator.ComputePosition())
<< "This is redundant result, we should not have. see "
"http://crbug.com/697283";
dom_iterator.Increment();
@@ -201,10 +201,10 @@ TEST_F(PositionIteratorTest, incrementWithSelectElement) {
EXPECT_EQ(PositionInFlatTree::BeforeNode(*select),
flat_iterator.ComputePosition());
flat_iterator.Increment();
- EXPECT_EQ(PositionInFlatTree::AfterNode(select),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*select),
flat_iterator.ComputePosition());
flat_iterator.Increment();
- EXPECT_EQ(PositionInFlatTree::AfterNode(select),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*select),
flat_iterator.ComputePosition())
<< "This is redundant result, we should not have. see "
"http://crbug.com/697283";
@@ -228,7 +228,7 @@ TEST_F(PositionIteratorTest, incrementWithTextAreaElement) {
dom_iterator.Increment();
EXPECT_EQ(Position::BeforeNode(*textarea), dom_iterator.ComputePosition());
dom_iterator.Increment();
- EXPECT_EQ(Position::AfterNode(textarea), dom_iterator.ComputePosition());
+ EXPECT_EQ(Position::AfterNode(*textarea), dom_iterator.ComputePosition());
dom_iterator.Increment();
EXPECT_EQ(Position(GetDocument().body(), 1), dom_iterator.ComputePosition());
dom_iterator.Increment();
@@ -244,7 +244,7 @@ TEST_F(PositionIteratorTest, incrementWithTextAreaElement) {
EXPECT_EQ(PositionInFlatTree::BeforeNode(*textarea),
flat_iterator.ComputePosition());
flat_iterator.Increment();
- EXPECT_EQ(PositionInFlatTree::AfterNode(textarea),
+ EXPECT_EQ(PositionInFlatTree::AfterNode(*textarea),
flat_iterator.ComputePosition());
flat_iterator.Increment();
EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 1),
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.cpp ('k') | third_party/WebKit/Source/core/editing/PositionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698