third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp - Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

index 3a156401f1a5a73f426182251b4ee6822a63bcae..19b8a96322398318c1b139edea9114fdd30e6ad2 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

@@ -1613,7 +1613,7 @@ void ApplyStyleCommand::SplitTextElementAtEnd(const Position& start,

should_update_start

? Position(ToText(first_text_node), start.OffsetInContainerNode())

: start;

- UpdateStartEnd(new_start, Position::AfterNode(first_text_node));

+ UpdateStartEnd(new_start, Position::AfterNode(*first_text_node));

}

bool ApplyStyleCommand::ShouldSplitTextElement(Element* element,