third_party/WebKit/Source/core/editing/SelectionModifier.cpp - Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionModifier.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionModifier.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp

index 139324ae6a7077d3695b3e6f3ac57bc74b5c6a51..8f61fe1fa784516402a161f533f32c5f48659894 100644

--- a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp

@@ -184,7 +184,7 @@ static void AdjustPositionForUserSelectAll(VisiblePosition& pos,

pos.DeepEquivalent().AnchorNode()))

pos = CreateVisiblePosition(

is_forward ? MostForwardCaretPosition(

- Position::AfterNode(root_user_select_all),

+ Position::AfterNode(*root_user_select_all),

kCanCrossEditingBoundary)

: MostBackwardCaretPosition(

Position::BeforeNode(*root_user_select_all),