third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp - Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

index 6b93ef65ba8194c49418d52b141e4ac23c69973e..434f829c5dcc4609c37f02d8f940e5f87884cf16 100644

--- a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

@@ -115,7 +115,7 @@ void FormatBlockCommand::FormatRange(const Position& start,

Position last_paragraph_in_block_node =

block_element->lastChild()

- ? Position::AfterNode(block_element->lastChild())

+ ? Position::AfterNode(*block_element->lastChild())

: Position();

bool was_end_of_paragraph =

IsEndOfParagraph(CreateVisiblePosition(last_paragraph_in_block_node));