third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp - Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

index 663e0253688a749a28d258aaa9d77be4680ed61c..2f2866dc3c0eb5f273f4f6e84882d4ecd34a4fa3 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

@@ -61,7 +61,7 @@ TEST_F(EditingUtilitiesTest, firstEditablePositionAfterPositionInRoot) {

Position(one->firstChild(), 0),

FirstEditableVisiblePositionAfterPositionInRoot(Position(three, 0), *host)

.DeepEquivalent());

- EXPECT_EQ(PositionInFlatTree::AfterNode(host),

+ EXPECT_EQ(PositionInFlatTree::AfterNode(*host),

FirstEditablePositionAfterPositionInRoot(

PositionInFlatTree(three, 0), *host));

EXPECT_EQ(PositionInFlatTree::LastPositionInNode(host),