Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index cdc1cd2234c757977d05a9fff9c47afca5dcf562..595aebbcbb9257028cb04d8d3d1972d57fd451ab 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -331,7 +331,7 @@ bool IsNodeFullyContained(const EphemeralRange& range, Node& node) {
return false;
return range.StartPosition() <= Position::BeforeNode(node) &&
- Position::AfterNode(&node) <= range.EndPosition();
+ Position::AfterNode(node) <= range.EndPosition();
}
// TODO(editing-dev): We should implement real version which refers
@@ -667,7 +667,7 @@ PositionTemplate<Strategy> FirstEditablePositionAfterPositionInRootAlgorithm(
if (!shadow_ancestor)
return PositionTemplate<Strategy>();
- editable_position = PositionTemplate<Strategy>::AfterNode(shadow_ancestor);
+ editable_position = PositionTemplate<Strategy>::AfterNode(*shadow_ancestor);
}
Node* non_editable_node = nullptr;
« no previous file with comments | « third_party/WebKit/Source/core/dom/RangeTest.cpp ('k') | third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698