Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2953683004: Make Position::AfterNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-22T12:37:16 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index e04ac10fca2b4828dfdd72ee0a1360c5c490d415..2d19525065905912dc4f112502438b980d347622 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -92,7 +92,7 @@ VisibleSelectionInFlatTree ExpandSelectionToRespectUserSelectAll(
PositionInFlatTree::BeforeNode(*root_user_select_all),
kCanCrossEditingBoundary))
.Extend(MostForwardCaretPosition(
- PositionInFlatTree::AfterNode(root_user_select_all),
+ PositionInFlatTree::AfterNode(*root_user_select_all),
kCanCrossEditingBoundary))
.Build());
}
@@ -318,7 +318,7 @@ static SelectionInFlatTree ApplySelectAll(
.SetBaseAndExtent(PositionInFlatTree::BeforeNode(
*root_user_select_all_for_mouse_press_node),
PositionInFlatTree::AfterNode(
- root_user_select_all_for_mouse_press_node))
+ *root_user_select_all_for_mouse_press_node))
.Build();
}
@@ -329,7 +329,7 @@ static SelectionInFlatTree ApplySelectAll(
TargetPositionIsBeforeDragStartPosition(
mouse_press_node, drag_start_point, target, hit_test_point)) {
builder.Collapse(PositionInFlatTree::AfterNode(
- root_user_select_all_for_mouse_press_node));
+ *root_user_select_all_for_mouse_press_node));
} else {
builder.Collapse(base_position);
}
@@ -343,7 +343,7 @@ static SelectionInFlatTree ApplySelectAll(
}
builder.Extend(
- PositionInFlatTree::AfterNode(root_user_select_all_for_target));
+ PositionInFlatTree::AfterNode(*root_user_select_all_for_target));
return builder.Build();
}

Powered by Google App Engine
This is Rietveld 408576698