Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

This CL affects instances of ASSERT() that have biary parameters mainly.

Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform.

BUG=707642, 707638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2879773002
Cr-Commit-Position: refs/heads/master@{#471594}
Committed: https://chromium.googlesource.com/chromium/src/+/46b2bede398821330e8901c3f95c5ce33b00213d

[gyuyoung2, 2017-05-12 03:15:44]

Description was changed from

==========
Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

This CL affects instances of ASSERT() that have biary parameters mainly.

Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform.

BUG=596760
==========

to

==========
Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

This CL affects instances of ASSERT() that have biary parameters mainly.

Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gyuyoung2, 2017-05-12 08:55:32]

gyuyoung.kim@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[tkent, 2017-05-12 09:00:18]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 09:00:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-12 09:04:01]

Description was changed from

==========
Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

This CL affects instances of ASSERT() that have biary parameters mainly.

Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

This CL affects instances of ASSERT() that have biary parameters mainly.

Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform.

BUG=707642, 707638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-05-12 09:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 09:04:03]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[tkent, 2017-05-12 09:04:37]

lgtm with some comments.

I updated BUG= line of the CL description.

https://codereview.chromium.org/2879773002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/navigatorcontentutils/testing/InternalsNavigatorContentUtils.cpp
(right):

https://codereview.chromium.org/2879773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/navigatorcontentutils/testing/InternalsNavigatorContentUtils.cpp:18:
DCHECK(document && document->GetPage());
Split this into two DCHECKs

https://codereview.chromium.org/2879773002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
(right):

https://codereview.chromium.org/2879773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp:481:
DCHECK(!messages_.IsEmpty() && messages_.front()->type == kMessageTypeBlob);
Split this into two DCHECKs

[haraken, 2017-05-12 09:27:55]

LGTM

[gyuyoung2, 2017-05-12 15:43:52]

The CQ bit was checked by gyuyoung.kim@chromium.org

[gyuyoung2, 2017-05-12 15:43:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2879773002/#ps20001
(title: "Apply review comments")

[commit-bot: I haz the power, 2017-05-12 15:44:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 16:24:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:24:14]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[gyuyoung2, 2017-05-13 05:29:32]

The CQ bit was checked by gyuyoung.kim@chromium.org

[commit-bot: I haz the power, 2017-05-13 05:29:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 06:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 06:03:59]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[gyuyoung2, 2017-05-13 06:09:51]

The CQ bit was checked by gyuyoung.kim@chromium.org

[commit-bot: I haz the power, 2017-05-13 06:09:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 06:39:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 06:39:55]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[gyuyoung2, 2017-05-13 06:50:07]

The CQ bit was checked by gyuyoung.kim@chromium.org

[gyuyoung2, 2017-05-13 06:50:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2879773002/#ps40001
(title: "Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules")

[commit-bot: I haz the power, 2017-05-13 06:50:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 07:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 07:28:54]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[gyuyoung2, 2017-05-13 07:39:44]

The CQ bit was checked by gyuyoung.kim@chromium.org

[gyuyoung2, 2017-05-13 07:39:45]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2879773002/#ps60001
(title: "Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules")

[commit-bot: I haz the power, 2017-05-13 07:39:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 11:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 11:09:11]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gyuyoung2, 2017-05-13 13:56:35]

The CQ bit was checked by gyuyoung.kim@chromium.org

[commit-bot: I haz the power, 2017-05-13 13:56:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 16:54:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494683795062020,
"parent_rev": "f6e95c3d37313a5de99cfadcb5ffd7a3595a1653", "commit_rev":
"46b2bede398821330e8901c3f95c5ce33b00213d"}

[commit-bot: I haz the power, 2017-05-13 16:55:05]

Description was changed from

==========
Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

This CL affects instances of ASSERT() that have biary parameters mainly.

Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform.

BUG=707642, 707638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

This CL affects instances of ASSERT() that have biary parameters mainly.

Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform.

BUG=707642, 707638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2879773002
Cr-Commit-Position: refs/heads/master@{#471594}
Committed:
https://chromium.googlesource.com/chromium/src/+/46b2bede398821330e8901c3f95c...
==========

[commit-bot: I haz the power, 2017-05-13 16:55:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/46b2bede398821330e8901c3f95c...