Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)
Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/cachestorage/InspectorCacheStorageAgent.h" 5 #include "modules/cachestorage/InspectorCacheStorageAgent.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 ResponsesAccumulator(int num_responses, 174 ResponsesAccumulator(int num_responses,
175 const DataRequestParams& params, 175 const DataRequestParams& params,
176 std::unique_ptr<RequestEntriesCallback> callback) 176 std::unique_ptr<RequestEntriesCallback> callback)
177 : params_(params), 177 : params_(params),
178 num_responses_left_(num_responses), 178 num_responses_left_(num_responses),
179 responses_(static_cast<size_t>(num_responses)), 179 responses_(static_cast<size_t>(num_responses)),
180 callback_(std::move(callback)) {} 180 callback_(std::move(callback)) {}
181 181
182 void AddRequestResponsePair(const WebServiceWorkerRequest& request, 182 void AddRequestResponsePair(const WebServiceWorkerRequest& request,
183 const WebServiceWorkerResponse& response) { 183 const WebServiceWorkerResponse& response) {
184 ASSERT(num_responses_left_ > 0); 184 DCHECK_GT(num_responses_left_, 0);
185 RequestResponse& request_response = 185 RequestResponse& request_response =
186 responses_.at(responses_.size() - num_responses_left_); 186 responses_.at(responses_.size() - num_responses_left_);
187 request_response.request = request.Url().GetString(); 187 request_response.request = request.Url().GetString();
188 request_response.response = response.StatusText(); 188 request_response.response = response.StatusText();
189 189
190 if (--num_responses_left_ != 0) 190 if (--num_responses_left_ != 0)
191 return; 191 return;
192 192
193 std::sort(responses_.begin(), responses_.end(), 193 std::sort(responses_.begin(), responses_.end(),
194 [](const RequestResponse& a, const RequestResponse& b) { 194 [](const RequestResponse& a, const RequestResponse& b) {
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 if (!response.isSuccess()) { 486 if (!response.isSuccess()) {
487 callback->sendFailure(response); 487 callback->sendFailure(response);
488 return; 488 return;
489 } 489 }
490 cache->DispatchOpen(WTF::MakeUnique<GetCacheForDeleteEntry>( 490 cache->DispatchOpen(WTF::MakeUnique<GetCacheForDeleteEntry>(
491 request, cache_name, std::move(callback)), 491 request, cache_name, std::move(callback)),
492 WebString(cache_name)); 492 WebString(cache_name));
493 } 493 }
494 494
495 } // namespace blink 495 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698