third_party/WebKit/Source/modules/crypto/CryptoKey.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/crypto/CryptoKey.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/crypto/CryptoKey.cpp

diff --git a/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp b/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp

index 7da91dab888fad22e69ca966c848aeb16257863e..4e68917fb97a78a1b67384363f3b450045b6bb0c 100644

--- a/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp

+++ b/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp

@@ -110,7 +110,7 @@ class DictionaryBuilder : public WebCryptoKeyAlgorithmDictionary {

virtual void SetAlgorithm(const char* property_name,

const WebCryptoAlgorithm& algorithm) {

- ASSERT(algorithm.ParamsType() == kWebCryptoAlgorithmParamsTypeNone);

+ DCHECK_EQ(algorithm.ParamsType(), kWebCryptoAlgorithmParamsTypeNone);

V8ObjectBuilder algorithm_value(builder_.GetScriptState());

algorithm_value.AddString(