third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp ('k') | third_party/WebKit/Source/modules/crypto/CryptoKey.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

index 0a703fccdfe38973451129bb681319aa15733bba..ff35965185a0314d8dca14c145930f627e48eadc 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

@@ -104,7 +104,7 @@ class RequestCallbacks : public WebCredentialManagerClient::RequestCallbacks {

return;

}

- ASSERT(credential->IsPasswordCredential() ||

+ DCHECK(credential->IsPasswordCredential() ||

credential->IsFederatedCredential());

UseCounter::Count(ExecutionContext::From(resolver_->GetScriptState()),

UseCounter::kCredentialManagerGetReturnedCredential);