Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)
Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
index 12940595678631d78227df85f0acede191070c03..6e892c19e25f1cca645d735ad0fac04db835a2f2 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
@@ -2875,7 +2875,7 @@ ScriptValue WebGLRenderingContextBase::getFramebufferAttachmentParameter(
return ScriptValue::CreateNull(script_state);
}
- ASSERT(attachment_object->IsTexture() || attachment_object->IsRenderbuffer());
+ DCHECK(attachment_object->IsTexture() || attachment_object->IsRenderbuffer());
if (attachment_object->IsTexture()) {
switch (pname) {
case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
@@ -6266,7 +6266,7 @@ void WebGLRenderingContextBase::LoseContextImpl(
return;
context_lost_mode_ = mode;
- ASSERT(context_lost_mode_ != kNotLostContext);
+ DCHECK_NE(context_lost_mode_, kNotLostContext);
auto_recovery_method_ = auto_recovery_method;
// Lose all the extensions.
@@ -6339,7 +6339,7 @@ Extensions3DUtil* WebGLRenderingContextBase::ExtensionsUtil() {
extensions_util_ = Extensions3DUtil::Create(gl);
// The only reason the ExtensionsUtil should be invalid is if the gl context
// is lost.
- ASSERT(extensions_util_->IsValid() ||
+ DCHECK(extensions_util_->IsValid() ||
gl->GetGraphicsResetStatusKHR() != GL_NO_ERROR);
}
return extensions_util_.get();

Powered by Google App Engine
This is Rietveld 408576698