third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

diff --git a/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

index 4fada831af47a4b9071d5c2ff13ca403e3b99037..ad24cc061728583652fb3b549c14de6a0b328efa 100644

--- a/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

+++ b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

@@ -66,7 +66,8 @@ void SetSinkIdResolver::StartAsync() {

void SetSinkIdResolver::TimerFired(TimerBase* timer) {

ExecutionContext* context = GetExecutionContext();

- ASSERT(context && context->IsDocument());

+ DCHECK(context);

+ DCHECK(context->IsDocument());

std::unique_ptr<SetSinkIdCallbacks> callbacks =

WTF::WrapUnique(new SetSinkIdCallbacks(this, *element_, sink_id_));

WebMediaPlayer* web_media_player = element_->GetWebMediaPlayer();

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/cachestorage/Cache.cpp » ('j') | no next file with comments »