Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)
Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
index f91cec74f26024c5553b6f5e7bb7fa0f15a0bf7e..33e748c195aeca73c723b3540a5feb52f5481c3b 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
@@ -610,7 +610,7 @@ bool WebGL2RenderingContextBase::CheckAndTranslateAttachments(
}
WebGLFramebuffer* framebuffer_binding = GetFramebufferBinding(target);
- ASSERT(framebuffer_binding || GetDrawingBuffer());
+ DCHECK(framebuffer_binding || GetDrawingBuffer());
if (!framebuffer_binding) {
// For the default framebuffer, translate GL_COLOR/GL_DEPTH/GL_STENCIL.
// The default framebuffer of WebGL is not fb 0, it is an internal fbo.
@@ -5313,7 +5313,7 @@ bool WebGL2RenderingContextBase::ValidateGetFramebufferAttachmentParameterFunc(
}
WebGLFramebuffer* framebuffer_binding = GetFramebufferBinding(target);
- ASSERT(framebuffer_binding || GetDrawingBuffer());
+ DCHECK(framebuffer_binding || GetDrawingBuffer());
if (!framebuffer_binding) {
// for the default framebuffer
switch (attachment) {
@@ -5364,7 +5364,7 @@ ScriptValue WebGL2RenderingContextBase::getFramebufferAttachmentParameter(
return ScriptValue::CreateNull(script_state);
WebGLFramebuffer* framebuffer_binding = GetFramebufferBinding(target);
- ASSERT(!framebuffer_binding || framebuffer_binding->Object());
+ DCHECK(!framebuffer_binding || framebuffer_binding->Object());
// Default framebuffer (an internal fbo)
if (!framebuffer_binding) {
@@ -5447,7 +5447,7 @@ ScriptValue WebGL2RenderingContextBase::getFramebufferAttachmentParameter(
return ScriptValue::CreateNull(script_state);
}
}
- ASSERT(attachment_object->IsTexture() || attachment_object->IsRenderbuffer());
+ DCHECK(attachment_object->IsTexture() || attachment_object->IsRenderbuffer());
switch (pname) {
case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:

Powered by Google App Engine
This is Rietveld 408576698