third_party/WebKit/Source/modules/webusb/USBInterface.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBInterface.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webusb/USBInterface.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USBInterface.cpp b/third_party/WebKit/Source/modules/webusb/USBInterface.cpp

index b4c0de8d1e3fa653351d113685adc8d6878473ef..b93032857cec3e1d106dda4d746cec588894e612 100644

--- a/third_party/WebKit/Source/modules/webusb/USBInterface.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USBInterface.cpp

@@ -37,9 +37,9 @@ USBInterface::USBInterface(const USBDevice* device,

: device_(device),

configuration_index_(configuration_index),

interface_index_(interface_index) {

- ASSERT(configuration_index_ < device_->Info().configurations.size());

- ASSERT(

- interface_index_ <

+ DCHECK_LT(configuration_index_, device_->Info().configurations.size());

+ DCHECK_LT(

+ interface_index_,

device_->Info().configurations[configuration_index_]->interfaces.size());

}