third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

index 6963be68297a6f917a4d87dfd8ff4aba930b4da3..a3f61711a6511679d10f984c616868fe3ede208a 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

@@ -456,7 +456,7 @@ void BaseRenderingContext2D::CompositedDraw(

CanvasRenderingContext2DState::PaintType paint_type,

CanvasRenderingContext2DState::ImageType image_type) {

sk_sp<SkImageFilter> filter = StateGetFilter();

- ASSERT(IsFullCanvasCompositeMode(GetState().GlobalComposite()) || filter);

+ DCHECK(IsFullCanvasCompositeMode(GetState().GlobalComposite()) || filter);

SkMatrix ctm = c->getTotalMatrix();

c->setMatrix(SkMatrix::I());

PaintFlags composite_flags;