third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

diff --git a/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp b/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

index eb7ddec8cbd0d9b48fea6842d77d78c8957fbc6e..02f037404613dbd4635906ccd968738681270bff 100644

--- a/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

+++ b/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

@@ -116,7 +116,7 @@ void NetworkInformation::RemoveAllEventListeners() {

}

bool NetworkInformation::HasPendingActivity() const {

- ASSERT(context_stopped_ || observing_ == HasEventListeners());

+ DCHECK(context_stopped_ || observing_ == HasEventListeners());

// Prevent collection of this object when there are active listeners.

return observing_;