Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)
Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webusb/USBDevice.cpp
diff --git a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
index 03bd0ff3592e2449b638811592d4278fe07b0d08..69d40e3cb070ff1428441fdb2c72169ed59aae55 100644
--- a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
+++ b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
@@ -281,7 +281,7 @@ ScriptPromise USBDevice::selectAlternateInterface(ScriptState* script_state,
if (EnsureInterfaceClaimed(interface_number, resolver)) {
// TODO(reillyg): This is duplicated work.
int interface_index = FindInterfaceIndex(interface_number);
- ASSERT(interface_index != -1);
+ DCHECK_NE(interface_index, -1);
int alternate_index =
FindAlternateIndex(interface_index, alternate_setting);
if (alternate_index == -1) {
@@ -486,7 +486,7 @@ int USBDevice::FindConfigurationIndex(uint8_t configuration_value) const {
}
int USBDevice::FindInterfaceIndex(uint8_t interface_number) const {
- ASSERT(configuration_index_ != -1);
+ DCHECK_NE(configuration_index_, -1);
const auto& interfaces =
Info().configurations[configuration_index_]->interfaces;
for (size_t i = 0; i < interfaces.size(); ++i) {
@@ -498,7 +498,7 @@ int USBDevice::FindInterfaceIndex(uint8_t interface_number) const {
int USBDevice::FindAlternateIndex(size_t interface_index,
uint8_t alternate_setting) const {
- ASSERT(configuration_index_ != -1);
+ DCHECK_NE(configuration_index_, -1);
const auto& alternates = Info()
.configurations[configuration_index_]
->interfaces[interface_index]

Powered by Google App Engine
This is Rietveld 408576698