third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

index a001e4ecd9d5e14746a35627f155eaecc29787b2..2bbaf7ec51dd389cb9ec6c5edc720a2f1a40215c 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

@@ -533,7 +533,7 @@ void WebGLFramebuffer::CommitWebGL1DepthStencilIfConsistent(GLenum target) {

GLenum WebGLFramebuffer::GetDrawBuffer(GLenum draw_buffer) {

int index = static_cast<int>(draw_buffer - GL_DRAW_BUFFER0_EXT);

- ASSERT(index >= 0);

+ DCHECK_GE(index, 0);

if (index < static_cast<int>(draw_buffers_.size()))

return draw_buffers_[index];

if (draw_buffer == GL_DRAW_BUFFER0_EXT)