third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp - Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

Issue 2879773002: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

index aba7a34ef7633b15c54ad7957e8082e64e9a0f45..d06c4b0a90736e1c8632abc5a141693e433c89da 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

@@ -122,7 +122,7 @@ ExceptionParams GetExceptionParams(const WebServiceWorkerError& web_error) {

DOMException* ServiceWorkerError::Take(ScriptPromiseResolver*,

const WebServiceWorkerError& web_error) {

ExceptionParams params = GetExceptionParams(web_error);

- ASSERT(params.code != kUnknownError);

+ DCHECK_NE(params.code, kUnknownError);

return DOMException::Create(params.code, params.message);

}