Allow binding multiple textures to one DC Layer overlay.

Allow binding multiple textures to one DC Layer overlay.

Modify ScheduleDCLayers command to take an array of textures.  This will
allow using NV12 shared-memory GpuMemoryBuffers, which will have
separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849743002
Cr-Commit-Position: refs/heads/master@{#469468}
Committed: https://chromium.googlesource.com/chromium/src/+/d817ddec78c9de78881a1661fa7f03e077d32d36

[jbauman, 2017-04-28 02:03:02]

Description was changed from

==========
Allow binding multiple textures to one DC Layer overlay.

This will allow using NV12 shared-memory GpuMemoryBuffers, which will
have separate Y and UV GLImages.

BUG=716286
==========

to

==========
Allow binding multiple textures to one DC Layer overlay.

This will allow using NV12 shared-memory GpuMemoryBuffers, which will
have separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-04-28 02:03:03]

Description was changed from

==========
Allow binding multiple textures to one DC Layer overlay.

This will allow using NV12 shared-memory GpuMemoryBuffers, which will
have separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow binding multiple textures to one DC Layer overlay.

This will allow using NV12 shared-memory GpuMemoryBuffers, which will
have separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-04-28 02:03:08]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:04:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:16:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:16:52]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbauman, 2017-04-28 02:23:17]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:24:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:49:52]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jbauman, 2017-04-28 02:57:04]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 02:57:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-04-28 03:00:40]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 03:01:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:03:20]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[jbauman, 2017-04-28 21:37:09]

Description was changed from

==========
Allow binding multiple textures to one DC Layer overlay.

This will allow using NV12 shared-memory GpuMemoryBuffers, which will
have separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow binding multiple textures to one DC Layer overlay.

Add a new command-buffer GL command to allow specifying multiple
independent textures that will be used by the next ScheduleDCLayers.
This will allow using NV12 shared-memory GpuMemoryBuffers, which will
have separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-04-28 22:19:31]

jbauman@chromium.org changed reviewers:
+ sunnyps@chromium.org

[jbauman, 2017-05-02 23:53:32]

jbauman@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2017-05-03 16:16:33]

I'd prefer that we pass an array to ScheduleDCLayer, something like

ScheduleDCLayerCHROMIUM(GLuint numTextures, GLuint* textures, ...

But, if you feel strongly that you'd rather add a separate function, then lgtm

https://codereview.chromium.org/2849743002/diff/60001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2849743002/diff/60001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:3272: contents_rect, dc_layer_overlay.background_color,
It may just be easier to have ScheduleDCLayerCHROMIUM take an arrays of
texture_ids, something like

ScheduleDCLayerCHROMIUM(GLuint numTextures, GLuint* textures)

[jbauman, 2017-05-03 23:45:50]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 23:46:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-05-04 00:45:31]

Description was changed from

==========
Allow binding multiple textures to one DC Layer overlay.

Add a new command-buffer GL command to allow specifying multiple
independent textures that will be used by the next ScheduleDCLayers.
This will allow using NV12 shared-memory GpuMemoryBuffers, which will
have separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow binding multiple textures to one DC Layer overlay.

Modify ScheduleDCLayers command to take an array of textures.  This will
allow using NV12 shared-memory GpuMemoryBuffers, which will have
separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-05-04 00:45:53]

On 2017/05/03 16:16:33, ccameron wrote:
> I'd prefer that we pass an array to ScheduleDCLayer, something like
> 
> ScheduleDCLayerCHROMIUM(GLuint numTextures, GLuint* textures, ...
> 
> But, if you feel strongly that you'd rather add a separate function, then lgtm
> 
> https://codereview.chromium.org/2849743002/diff/60001/cc/output/gl_renderer.cc
> File cc/output/gl_renderer.cc (right):
> 
>
https://codereview.chromium.org/2849743002/diff/60001/cc/output/gl_renderer.c...
> cc/output/gl_renderer.cc:3272: contents_rect,
dc_layer_overlay.background_color,
> It may just be easier to have ScheduleDCLayerCHROMIUM take an arrays of
> texture_ids, something like
> 
> ScheduleDCLayerCHROMIUM(GLuint numTextures, GLuint* textures)

Ok, modified to do that.

[commit-bot: I haz the power, 2017-05-04 00:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 00:49:25]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-05-04 20:57:40]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-05-04 20:57:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2849743002/#ps80001
(title: "put texture id array in ScheduleDCLayer")

[commit-bot: I haz the power, 2017-05-04 20:58:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 21:05:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493931460303420,
"parent_rev": "cbb8751cd7410acdb6535865a0a1beb41051fc96", "commit_rev":
"d817ddec78c9de78881a1661fa7f03e077d32d36"}

[commit-bot: I haz the power, 2017-05-04 21:05:31]

Description was changed from

==========
Allow binding multiple textures to one DC Layer overlay.

Modify ScheduleDCLayers command to take an array of textures.  This will
allow using NV12 shared-memory GpuMemoryBuffers, which will have
separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow binding multiple textures to one DC Layer overlay.

Modify ScheduleDCLayers command to take an array of textures.  This will
allow using NV12 shared-memory GpuMemoryBuffers, which will have
separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849743002
Cr-Commit-Position: refs/heads/master@{#469468}
Committed:
https://chromium.googlesource.com/chromium/src/+/d817ddec78c9de78881a1661fa7f...
==========

[commit-bot: I haz the power, 2017-05-04 21:05:32]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d817ddec78c9de78881a1661fa7f...