Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Use non-const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

BUG=637460
Review-Url: https://codereview.chromium.org/2849403002
Cr-Commit-Position: refs/heads/master@{#468587}
Committed: https://chromium.googlesource.com/chromium/src/+/bed8311f2e1d29053f198a429b71653a6888088a

[joelhockey, 2017-05-02 06:58:37]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 06:58:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-05-02 07:02:29]

joelhockey@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[joelhockey, 2017-05-02 07:02:29]

I'm still getting up to speed with C++ language features and the blink style
guidelines, but this change to make LocalFrame::LocalFrameRoot and
FrameTree::Top to be non-nullable refs seems like a good change to me.

[commit-bot: I haz the power, 2017-05-02 07:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 07:14:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-05-02 07:21:55]

LGTM

https://codereview.chromium.org/2849403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2849403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:382: CHECK(frame_ ==
&frame_->LocalFrameRoot());

ASSERT should be replaced with DCHECK.

[joelhockey, 2017-05-02 07:48:23]

https://codereview.chromium.org/2849403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2849403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:382: CHECK(frame_ ==
&frame_->LocalFrameRoot());
On 2017/05/02 at 07:21:54, haraken wrote:
> ASSERT should be replaced with DCHECK.

thanks, I've made them all DCHECK_EQ

[joelhockey, 2017-05-02 07:49:11]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 07:49:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-05-02 07:50:22]

LGTM

(though const ref isn't quite accurate, we're returning mutable refs, so maybe
update the CL description)

[joelhockey, 2017-05-02 07:53:13]

Description was changed from

==========
Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

BUG=637460
==========

to

==========
Use mutable ref for LocalFrame::LocalFrameRoot and FrameTree::Top

BUG=637460
==========

[joelhockey, 2017-05-02 07:53:25]

The CQ bit was unchecked by joelhockey@chromium.org

[joelhockey, 2017-05-02 07:53:28]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-05-02 07:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2849403002/#ps20001
(title: "fix compile and dchecks")

[commit-bot: I haz the power, 2017-05-02 07:53:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-05-02 08:55:34]

On 2017/05/02 at 07:50:22, dcheng wrote:
> LGTM
> 
> (though const ref isn't quite accurate, we're returning mutable refs, so maybe
update the CL description)

Thanks Daniel.  I just realised that 'non-const ref' are the words I was
thinking of.

[joelhockey, 2017-05-02 08:55:41]

Description was changed from

==========
Use mutable ref for LocalFrame::LocalFrameRoot and FrameTree::Top

BUG=637460
==========

to

==========
Use non-const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

BUG=637460
==========

[commit-bot: I haz the power, 2017-05-02 09:16:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493711608005000,
"parent_rev": "77afe7a6999e1592b462aa8ebc0da11ee92ed59d", "commit_rev":
"bed8311f2e1d29053f198a429b71653a6888088a"}

[commit-bot: I haz the power, 2017-05-02 09:16:30]

Description was changed from

==========
Use non-const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

BUG=637460
==========

to

==========
Use non-const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

BUG=637460

Review-Url: https://codereview.chromium.org/2849403002
Cr-Commit-Position: refs/heads/master@{#468587}
Committed:
https://chromium.googlesource.com/chromium/src/+/bed8311f2e1d29053f198a429b71...
==========

[commit-bot: I haz the power, 2017-05-02 09:16:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bed8311f2e1d29053f198a429b71...