third_party/WebKit/Source/core/timing/Performance.cpp - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/Performance.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: fix compile and dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/timing/Performance.cpp

diff --git a/third_party/WebKit/Source/core/timing/Performance.cpp b/third_party/WebKit/Source/core/timing/Performance.cpp

index ef4dcfdfe2d2ad2954593c14e9fba100ca3f8ab1..15ae69b94f917ca8ae710b40842374fd27c0eca7 100644

--- a/third_party/WebKit/Source/core/timing/Performance.cpp

+++ b/third_party/WebKit/Source/core/timing/Performance.cpp

@@ -155,7 +155,7 @@ void Performance::UpdateLongTaskInstrumentation() {

return;

if (HasObserverFor(PerformanceEntry::kLongTask)) {

- UseCounter::Count(GetFrame()->LocalFrameRoot(),

+ UseCounter::Count(&GetFrame()->LocalFrameRoot(),

UseCounter::kLongTaskObserver);

GetFrame()->GetPerformanceMonitor()->Subscribe(

PerformanceMonitor::kLongTask, kLongTaskThreshold, this);