Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)
Patch Set: fix compile and dchecks Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
index 1481a91e9a934dbbfbbd234ec868e14438f32018..57d40aaa5e08bf2f21e50010cf2c9cbeca1d7054 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
@@ -942,7 +942,7 @@ std::unique_ptr<TracedValue> FrameEventData(LocalFrame* frame) {
std::unique_ptr<TracedValue> value = TracedValue::Create();
bool is_main_frame = frame && frame->IsMainFrame();
value->SetBoolean("isMainFrame", is_main_frame);
- value->SetString("page", ToHexString(frame->LocalFrameRoot()));
+ value->SetString("page", ToHexString(&frame->LocalFrameRoot()));
return value;
}
@@ -1147,7 +1147,7 @@ std::unique_ptr<TracedValue> InspectorTracingStartedInFrame::Data(
LocalFrame* frame) {
std::unique_ptr<TracedValue> value = TracedValue::Create();
value->SetString("sessionId", session_id);
- value->SetString("page", ToHexString(frame->LocalFrameRoot()));
+ value->SetString("page", ToHexString(&frame->LocalFrameRoot()));
value->BeginArray("frames");
for (Frame* f = frame; f; f = f->Tree().TraverseNext(frame)) {
if (!f->IsLocalFrame())

Powered by Google App Engine
This is Rietveld 408576698