Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 436 matching lines @@
 }
 
 void ChromeClientImpl::SetResizable(bool value) {
   window_features_.resizable = value;
 }
 
 bool ChromeClientImpl::ShouldReportDetailedMessageForSource(
     LocalFrame& local_frame,
     const String& url) {
   WebLocalFrameImpl* webframe =
-      WebLocalFrameImpl::FromFrame(local_frame.LocalFrameRoot());
+      WebLocalFrameImpl::FromFrame(&local_frame.LocalFrameRoot());
   return webframe && webframe->Client() &&
          webframe->Client()->ShouldReportDetailedMessageForSource(url);
 }
 
 void ChromeClientImpl::AddMessageToConsole(LocalFrame* local_frame,
                                            MessageSource source,
                                            MessageLevel level,
                                            const String& message,
                                            unsigned line_number,
                                            const String& source_id,
@@ skipping 80 matching lines @@
 bool ChromeClientImpl::TabsToLinks() {
   return web_view_->TabsToLinks();
 }
 
 void ChromeClientImpl::InvalidateRect(const IntRect& update_rect) {
   if (!update_rect.IsEmpty())
     web_view_->InvalidateRect(update_rect);
 }
 
 void ChromeClientImpl::ScheduleAnimation(LocalFrame* frame) {
-  frame = frame->LocalFrameRoot();
+  frame = &frame->LocalFrameRoot();
   // If the frame is still being created, it might not yet have a WebWidget.
   // FIXME: Is this the right thing to do? Is there a way to avoid having
   // a local frame root that doesn't have a WebWidget? During initialization
   // there is no content to draw so this call serves no purpose.
   if (WebLocalFrameImpl::FromFrame(frame) &&
       WebLocalFrameImpl::FromFrame(frame)->FrameWidget())
     WebLocalFrameImpl::FromFrame(frame)->FrameWidget()->ScheduleAnimation();
 }
 
 IntRect ChromeClientImpl::ViewportToScreen(
     const IntRect& rect_in_viewport,
     const FrameViewBase* frame_view_base) const {
   WebRect screen_rect(rect_in_viewport);
 
   DCHECK(frame_view_base->IsFrameView());
   const FrameView* view = ToFrameView(frame_view_base);
-  LocalFrame* frame = view->GetFrame().LocalFrameRoot();
+  LocalFrame& frame = view->GetFrame().LocalFrameRoot();
 
   WebWidgetClient* client =
-      WebLocalFrameImpl::FromFrame(frame)->FrameWidget()->Client();
+      WebLocalFrameImpl::FromFrame(&frame)->FrameWidget()->Client();
 
   if (client) {
     client->ConvertViewportToWindow(&screen_rect);
     WebRect view_rect = client->ViewRect();
     screen_rect.x += view_rect.x;
     screen_rect.y += view_rect.y;
   }
 
   return screen_rect;
 }
@@ skipping 185 matching lines @@
   if (cursor_overridden_)
     return;
 
 #if OS(MACOSX)
   // On Mac the mousemove event propagates to both the popup and main window.
   // If a popup is open we don't want the main window to change the cursor.
   if (web_view_->HasOpenedPopup())
     return;
 #endif
 
-  LocalFrame* local_root = local_frame->LocalFrameRoot();
+  LocalFrame& local_root = local_frame->LocalFrameRoot();
   if (WebFrameWidgetBase* widget =
-          WebLocalFrameImpl::FromFrame(local_root)->FrameWidget())
+          WebLocalFrameImpl::FromFrame(&local_root)->FrameWidget())
     widget->Client()->DidChangeCursor(cursor);
 }
 
 void ChromeClientImpl::SetCursorForPlugin(const WebCursorInfo& cursor,
                                           LocalFrame* local_frame) {
   SetCursor(cursor, local_frame);
 }
 
 void ChromeClientImpl::SetCursorOverridden(bool overridden) {
   cursor_overridden_ = overridden;
@@ skipping 74 matching lines @@
 void ChromeClientImpl::ExitFullscreen(LocalFrame& frame) {
   web_view_->ExitFullscreen(frame);
 }
 
 void ChromeClientImpl::FullscreenElementChanged(Element* from_element,
                                                 Element* to_element) {
   web_view_->FullscreenElementChanged(from_element, to_element);
 }
 
 void ChromeClientImpl::ClearCompositedSelection(LocalFrame* frame) {
-  LocalFrame* local_root = frame->LocalFrameRoot();
+  LocalFrame& local_root = frame->LocalFrameRoot();
   WebFrameWidgetBase* widget =
-      WebLocalFrameImpl::FromFrame(local_root)->FrameWidget();
+      WebLocalFrameImpl::FromFrame(&local_root)->FrameWidget();
   WebWidgetClient* client = widget->Client();
   if (!client)
     return;
 
   if (WebLayerTreeView* layer_tree_view = widget->GetLayerTreeView())
     layer_tree_view->ClearSelection();
 }
 
 void ChromeClientImpl::UpdateCompositedSelection(
     LocalFrame* frame,
     const CompositedSelection& selection) {
-  LocalFrame* local_root = frame->LocalFrameRoot();
+  LocalFrame& local_root = frame->LocalFrameRoot();
   WebFrameWidgetBase* widget =
-      WebLocalFrameImpl::FromFrame(local_root)->FrameWidget();
+      WebLocalFrameImpl::FromFrame(&local_root)->FrameWidget();
   WebWidgetClient* client = widget->Client();
   if (!client)
     return;
 
   if (WebLayerTreeView* layer_tree_view = widget->GetLayerTreeView())
     layer_tree_view->RegisterSelection(WebSelection(selection));
 }
 
 bool ChromeClientImpl::HasOpenedPopup() const {
   return web_view_->HasOpenedPopup();
@@ skipping 140 matching lines @@
   WebLocalFrameImpl* web_frame = WebLocalFrameImpl::FromFrame(frame);
   WebFrameWidgetBase* widget = web_frame->LocalRoot()->FrameWidget();
   if (!widget)
     return;
 
   if (WebWidgetClient* client = widget->Client())
     client->SetTouchAction(static_cast<WebTouchAction>(touch_action));
 }
 
 bool ChromeClientImpl::RequestPointerLock(LocalFrame* frame) {
-  LocalFrame* local_root = frame->LocalFrameRoot();
-  return WebLocalFrameImpl::FromFrame(local_root)
+  LocalFrame& local_root = frame->LocalFrameRoot();
+  return WebLocalFrameImpl::FromFrame(&local_root)
       ->FrameWidget()
       ->Client()
       ->RequestPointerLock();
 }
 
 void ChromeClientImpl::RequestPointerUnlock(LocalFrame* frame) {
-  LocalFrame* local_root = frame->LocalFrameRoot();
-  return WebLocalFrameImpl::FromFrame(local_root)
+  LocalFrame& local_root = frame->LocalFrameRoot();
+  return WebLocalFrameImpl::FromFrame(&local_root)
       ->FrameWidget()
       ->Client()
       ->RequestPointerUnlock();
 }
 
 void ChromeClientImpl::AnnotatedRegionsChanged() {
   if (WebViewClient* client = web_view_->Client())
     client->DraggableRegionsChanged();
 }
 
@@ skipping 161 matching lines @@
   if (RuntimeEnabledFeatures::presentationEnabled())
     PresentationController::ProvideTo(frame, client->PresentationClient());
   if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
     ProvideAudioOutputDeviceClientTo(frame,
                                      new AudioOutputDeviceClientImpl(frame));
   }
   InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
 }
 
 }  // namespace blink