third_party/WebKit/Source/core/editing/FrameSelection.cpp - Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2849403002: Use const ref for LocalFrame::LocalFrameRoot and FrameTree::Top (Closed)

Patch Set: fix compile and dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

index 87ec20377a9264488e300255fbd46ffb3ea3af8e..766fc521105c1f2e2c4e8caf63c1c28144846acb 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

@@ -1048,7 +1048,7 @@ DEFINE_TRACE(FrameSelection) {

void FrameSelection::ScheduleVisualUpdate() const {

if (Page* page = frame_->GetPage())

- page->Animator().ScheduleVisualUpdate(frame_->LocalFrameRoot());

+ page->Animator().ScheduleVisualUpdate(&frame_->LocalFrameRoot());

}

void FrameSelection::ScheduleVisualUpdateForPaintInvalidationIfNeeded() const {